R Support [WIP] #349
Closed
R Support [WIP] #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into cran-branch
…into cran-branch
|
|
Comment on lines
+146
to
+148
| # Due to how the metadata is rendered there can be | ||
| # significant areas of repeated newlines. | ||
| # This collapses them and also strips any trailing spaces. |
There was a problem hiding this comment.
All those comments that you put before the function, can you move them to be the function docstring please?
|
|
||
| def get_cran_archive_versions(cran_url, session, package, verbose=True): | ||
| if verbose: | ||
| print(f"Fetching archived versions for package {package} from {cran_url}") |
There was a problem hiding this comment.
Can you use log, or can you use print_msg from grayskull.cli.stdout please?
|
|
||
| cran_url = "https://cran.r-project.org" | ||
|
|
||
|
|
There was a problem hiding this comment.
can you create unit tests for those free functions in this file please?
| recipe = GrayskullFactory.create_recipe( | ||
| "pypi", Configuration(name="pytest", version="5.3.2") | ||
| ) | ||
| # The CRAN test is not passing. I don't understand why! |
There was a problem hiding this comment.
you also need to change line 124 to
cli.main([index, str(recipe_path), "--sections", "requirements"])Co-authored-by: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>
Co-authored-by: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>
Merged
|
Closing this in favor of #423 Thank you very much for your hard work and all effort that you put into this! |
This was referenced Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Add CRAN origin to Grayskull.
These changes only aim to handle simple R recipes.
The functionality to extract compiler information from R metadata and therefore handle complex packages will be added in consequent iterations.
ToDo
(It is not a requirement to have the packages listed in a sorted order. But it's a nice to have, as it improves readability for users trying to look for a specific package in the list)