Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selectors for empty packages. #357

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

marcelotrevisani
Copy link
Member

It needs to be configured in the config.yaml for pypi packages only.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 26, 2022

This pull request fixes 1 alert when merging 70194ae into 00753f7 - view on LGTM.com

fixed alerts:

  • 1 for Wrong number of arguments in a class instantiation

@marcelotrevisani marcelotrevisani force-pushed the fb-216-avoid-selector-empty-packages branch from 70194ae to 13376b7 Compare July 26, 2022 11:38
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 26, 2022

This pull request fixes 1 alert when merging 13376b7 into 00753f7 - view on LGTM.com

fixed alerts:

  • 1 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 26, 2022

This pull request fixes 1 alert when merging 5c977c1 into 00753f7 - view on LGTM.com

fixed alerts:

  • 1 for Wrong number of arguments in a class instantiation

@codecov-commenter
Copy link

Codecov Report

Merging #357 (5c977c1) into main (9c3242e) will decrease coverage by 0.11%.
The diff coverage is 92.19%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   91.30%   91.19%   -0.12%     
==========================================
  Files          17       16       -1     
  Lines        1576     1590      +14     
==========================================
+ Hits         1439     1450      +11     
- Misses        137      140       +3     
Flag Coverage Δ
unittests 91.19% <92.19%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
grayskull/base/github.py 72.83% <72.83%> (ø)
grayskull/license/discovery.py 94.87% <78.12%> (-2.28%) ⬇️
grayskull/strategy/abstract_strategy.py 83.33% <83.33%> (ø)
grayskull/__main__.py 95.40% <92.50%> (-2.75%) ⬇️
grayskull/base/factory.py 91.17% <93.33%> (+1.17%) ⬆️
grayskull/strategy/py_base.py 95.05% <95.05%> (ø)
grayskull/utils.py 97.38% <96.58%> (-2.62%) ⬇️
grayskull/config.py 96.77% <96.77%> (ø)
grayskull/strategy/pypi.py 97.33% <97.33%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@marcelotrevisani marcelotrevisani merged commit 722a91c into main Jul 26, 2022
@marcelotrevisani marcelotrevisani deleted the fb-216-avoid-selector-empty-packages branch July 26, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Be aware of empty packages for certain python versions
2 participants