Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinx-argparse documentation #457

Merged
merged 14 commits into from
Apr 10, 2023

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Mar 27, 2023

Description

This includes sphinx-argparse documentation for grayskull's cli. The cli was moved into a file not called __main__ and rearranged a bit to make it clear we can import the parser without running the tool. A workflow should automatically publish these to github pages if the project is set up to accept pages from a workflow, instead of a special branch.

It would be nice to include README.md in the documentation, like https://github.com/conda/conda-package-streaming/blob/main/docs/index.md?plain=1#L26 ; had some trouble with sphinx errors when doing so.

@dholth dholth requested a review from a team as a code owner March 27, 2023 17:51
Copy link
Contributor

@ForgottenProgramme ForgottenProgramme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating text based on latest release

docs/source/index.md Outdated Show resolved Hide resolved
docs/source/index.md Outdated Show resolved Hide resolved
dholth and others added 2 commits March 28, 2023 09:12
Co-authored-by: Mahe Iram Khan <65779580+ForgottenProgramme@users.noreply.github.com>
@marcelotrevisani
Copy link
Member

is that ready for review?

@dholth
Copy link
Contributor Author

dholth commented Mar 30, 2023

is that ready for review?

Yes, this PR is ready for review.

If it is merged, follow this documentation to allow the workflow to publish pages. https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow

@marcelotrevisani
Copy link
Member

Sorry for my delay
Thanks a lot for the contribution

@marcelotrevisani marcelotrevisani merged commit 1868cbb into conda:main Apr 10, 2023
@dholth
Copy link
Contributor Author

dholth commented Apr 10, 2023

@marcelotrevisani it looks like you need to set up github actions as a source for github pages, and then re-run the sphinx workflow. You can find me on the conda-forge chat if that would help.

@dholth
Copy link
Contributor Author

dholth commented Apr 10, 2023

It works!

@BastianZim
Copy link
Contributor

Is there a link to the docs? I can't seem to find where they are deployed.

@jezdez
Copy link
Member

jezdez commented Jun 6, 2023

@BastianZim https://conda.github.io/grayskull/

@marcelotrevisani there was an issue with the GitHub pages setting of the repo, it was still set up to deploy from the gh-pages branch (you can probably delete this now), and not directly via github actions, which is GitHub's new pages API

@BastianZim
Copy link
Contributor

Oh nice -- thanks!

Might be good to link that in the readme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants