Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use semver 3.0 #464

Merged
merged 1 commit into from
May 17, 2023
Merged

use semver 3.0 #464

merged 1 commit into from
May 17, 2023

Conversation

ocefpaf
Copy link
Contributor

@ocefpaf ocefpaf commented May 5, 2023

Latest semver changed this method from isvalid to is_valid.

@ocefpaf ocefpaf requested a review from a team as a code owner May 5, 2023 16:08
ocefpaf
ocefpaf commented May 5, 2023
View reviewed changes
pyproject.toml
@@ -26,7 +26,7 @@ dependencies = [
"ruamel.yaml >=0.16.10",
"ruamel.yaml.jinja2",
"setuptools >=30.3.0",
"semver~=2.13.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, b/c of this, grayskull should not install semver 3.0.0, right? Anyway, I got it in my env and it broke grayskull. This PR makes it a bit future proof.

@marcelotrevisani
Copy link
Member

sorry for my delay.
Yeah, that is indeed nice to update semver version as well

@marcelotrevisani marcelotrevisani enabled auto-merge (squash) May 9, 2023 08:50
@ocefpaf
Copy link
Contributor Author

ocefpaf commented May 9, 2023

sorry for my delay.

No rush.

@marcelotrevisani
Copy link
Member

gonna need to add your modifications to my other PR, is that ok?

@marcelotrevisani
Copy link
Member

@jezdez I cannot merge this one, there is an unrelated problem with a new version of rapidfuzz that is affecting this PR that I would prefer to fix in separated PR. However, I do not have rights to bypass this!?

@marcelotrevisani marcelotrevisani merged commit b926438 into conda:main May 17, 2023
@jezdez
Copy link
Member

jezdez commented May 17, 2023

@marcelotrevisani the branch protection requires passing the status checks, Tests / run (ubuntu-latest, 3.8) etc, I've just deactivated it, this is merely a precaution and should be helpful and not blocking you of course. Apologies that it was in the way.

@jezdez
Copy link
Member

jezdez commented May 17, 2023

@marcelotrevisani I assumed you'd have access to the branch protection settings given your maintain permissions, but I must have been mistaken about that.

@jezdez
Copy link
Member

jezdez commented May 17, 2023

Should I enable the option to require status checks again?

@ocefpaf ocefpaf deleted the fix_semver_version branch May 17, 2023 18:19
@marcelotrevisani
Copy link
Member

Hi @jezdez , I don't have permission to change those options....
And it is also blocking me, can you please remove all those require status checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelotrevisani marcelotrevisani marcelotrevisani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ocefpaf @marcelotrevisani @jezdez