Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore utf-8 decoding errors #479

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

boldorider4
Copy link
Contributor

Description

During license discovery, non UTF-8 characters can break the recipe creation. This fix allows ignoring such characters.

@boldorider4 boldorider4 requested a review from a team as a code owner August 9, 2023 07:47
@marcelotrevisani
Copy link
Member

Hey @boldorider4 ,

Thanks for your contribution. Can you just give me an example please?

@boldorider4
Copy link
Contributor Author

Hey @boldorider4 ,

Thanks for your contribution. Can you just give me an example please?

An example would be a name in a license file that contains non-utf-8 characters such as Chinese or Arabic.

@marcelotrevisani
Copy link
Member

marcelotrevisani commented Aug 9, 2023

Hey @boldorider4 ,
Thanks for your contribution. Can you just give me an example please?

An example would be a name in a license file that contains non-utf-8 characters such as Chinese or Arabic.

cool cool, do you have a project example for me to just take a look please? :)

it can be a project on pypi or something like that

@boldorider4
Copy link
Contributor Author

boldorider4 commented Aug 9, 2023

cool cool, do you have a project example for me to just take a look please? :)

it can be a project on pypi or something like that

I've had problems creating a recipe for pypdfium2.

@marcelotrevisani marcelotrevisani enabled auto-merge (squash) August 11, 2023 12:29
@marcelotrevisani marcelotrevisani merged commit 2c54cff into conda:main Aug 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants