Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on license match #507

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fix crash on license match #507

merged 2 commits into from
Nov 1, 2023

Commits on Nov 1, 2023

  1. Add test for GPLv3 license name 

    This currently fails with:

>               if original_matches[0][1] < 0.55:
E               IndexError: list index out of range

grayskull/license/discovery.py:105: IndexError
    @beenje
    beenje committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d0d5106 View commit details
    Browse the repository at this point in the history

  2. Fix crash and improve license discovery 

    - check if original_matches isn't empty
- only remove "-only" license only if there is an existing "-or-later" identical license
- add more test cases for GPL licenses
    @beenje
    beenje committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    82ed56c View commit details
    Browse the repository at this point in the history