Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify a package server mirror; clean up hardcoded URLs throughout codebase #540

Merged

Conversation

FaustinCarter
Copy link
Contributor

Summary

Add in new --pypi-mirror-url and --pypi-metadata-url CLI options and deprecate --pypi-url

Description

I want to build conda packages for python packages hosted on an internal package server that follows the pypi.org API. Unfortunately, https://pypi.org is hardcoded into the strategy.pypi module making this impossible.

This PR adds two new options to the pypi argument parser:

  • --pypi-mirror-url: URL for a mirror intended to replace https://pypi.org that follows the same API (see Sonatype Nexus, Artifactory, or Gitlab's internal python registry)
  • --pypi-metadata-url: URL from which to pull json metadata about the hosted package (it's possible that a user may want to specify this explicitly if their internal mirror/server does not support the pypi/{package name}/json endpoint

This PR deprecates the existing --pypi-url option, while retaining the original functionality.

This PR additionally adds some information to the README about how to use the new options.

@FaustinCarter FaustinCarter requested a review from a team as a code owner May 24, 2024 19:32
@FaustinCarter FaustinCarter force-pushed the feature_add-option-for-pypi-mirror branch from ca5cca6 to c0c4ec7 Compare May 24, 2024 19:49
@marcelotrevisani marcelotrevisani merged commit ede342b into conda:main Aug 4, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants