Split parsing of Poetry versions into a separate module #557
Conversation
Ensure that the regex applies to the entire string.
…t and keep both files
…e file to target-name
…e source-file to temp
…ve conflict and keep both files
…re name of source-file
|
Ok, the only failing tests now are |
|
Please have a look at this particular commit: maresb@d367c16 There is an extra whitespace character before |
| @@ -38,7 +38,7 @@ jobs: | |||
| - name: Running serial tests | |||
There was a problem hiding this comment.
can you revert this and add a new step to run the doctests please?
I think it would be better to have the doctests running step separated from the unittests
There was a problem hiding this comment.
Cool, thanks so much for the review!
I can certainly rearrange the tests, but could you explain a bit about the current structure so that I can implement it correctly? In particular, should the doctests execute before or after the serial/parallel tests?
I don't understand why the tests are currently split into serial/parallel, and from what I can see they are executing in exactly the same context, so I'm confused. By default, unless there's some good reason, I'd expect the tests to run all together in the same job, so that if some of the tests fail then you see all the failing tests rather than only the failing tests in the particular job.
There was a problem hiding this comment.
The tests are split into serial and parallel because the serial tests can interfere with other tests and make them fail.
|
that is a nice refactoring, thank you for that! |
This makes it more self-contained
Please review carefully. The results changed but I know neither R nor the intention.
maresb
force-pushed
the
copy-py-toml
branch
2 times, most recently
from
1c2d8ad
to
9ded459
Compare
|
I backed out of the merge commit and moved the "Enable doctests" commit to be redone to the end. I will modify it and then redo the merge commit. At this point there are no changes to the code, only shuffling around commits. |
maresb
force-pushed
the
copy-py-toml
branch
from
9ded459
to
511ed85
Compare
|
@marcelotrevisani, I made an initial guess about what you want. No problem to change it if you'd like it done differently. |
maresb
force-pushed
the
copy-py-toml
branch
from
15a1c66
to
1432f07
Compare
|
My previous attempt to split the doctests was broken, but I fixed it and now the CI is green. |
|
Thanks a lot! |
|
Wonderful, thank you @marcelotrevisani!!! |
Description
While working on conda-lock I noticed that our parsing of pyproject.toml files is incorrect. I'd like to copy it from here. In preparation for this I cleaned up some stuff and split it into a separate module.
When splitting the files I did some fancy Git tricks to preserve the blame history. (That's what the "Split history ..." commits are about.)
Also, as a personal preference, for unit tests regarding the nominal operation of functions I really like doctests. I enabled them. Of course if you don't like that I can revert those commits.
While this PR as a whole may be somewhat confusing, I really try to make each individual commit really easy and quick to understand and verify. I hope I achieved that, but if not, please ask. Thanks a lot for your time!