Test on more versions of Python #563
Conversation
|
Ok, conda-recipe-manager fails unless Python >=3.11 |
|
Probably the right thing to do is conditionally install conda-recipe-manager on Python >=3.11 and then conditionally run only the tests that actually need it. |
|
yeah, that is due to the fact that |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -163,7 +164,7 @@ | |||
| return recipe_license["licenseId"] | |||
|
|
|||
|
|
|||
| def _get_license(license_id: str, all_licenses: List) -> dict: | |||
| def _get_license(license_id: str, all_licenses: list) -> dict: | |||
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
| @@ -41,7 +42,7 @@ | |||
| PIN_PKG_COMPILER = {"numpy": "<{ pin_compatible('numpy') }}"} | |||
|
|
|||
|
|
|||
| def search_setup_root(path_folder: Union[Path, str]) -> Path: | |||
| def search_setup_root(path_folder: Path | str) -> Path: | |||
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
|
It looks like there is no coverage yet for |
|
Oops, seems to be hitting mamba-org/setup-micromamba#225 |
maresb
force-pushed
the
patch-2
branch
3 times, most recently
from
e8398e8
to
a078d44
Compare
|
@marcelotrevisani, what do you think of these changes? Tests are now passing down to Python 3.8. In order to get there I had to I removed Finally, I switched from |
environment.yaml
Outdated
| @@ -29,4 +29,4 @@ dependencies: | |||
| - libcblas | |||
| - beautifulsoup4 | |||
| - semver >=3.0.0,<4.0.0 | |||
| - conda-recipe-manager >=0.2.0 | |||
| - micromamba | |||
There was a problem hiding this comment.
do we need micromamba here? 😬
| raise ImportError( | ||
| "Please install conda-recipe-manager from conda-forge to enable " | ||
| "support for the V1 format. (Note that Python >=3.11 is required.)" | ||
| ) from e |
|
hey, thanks again for this PR, I just added one comment about micromamba in the environment.yaml, do we need it there? |
|
Ah, very good point!!! Now that I switched the CI over to I just rebased to remove the commit where I added it. (See the rebase diff with the "Compare" button or equivalently here.) |
|
@marcelotrevisani, yep, it's working. The relevant part of CI has completed. |
Description
Dual to #562 let's check which Python versions work.