Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fish format variable #264

Merged
merged 3 commits into from
Jul 14, 2023
Merged

fix: fish format variable #264

merged 3 commits into from
Jul 14, 2023

Conversation

ruben-arts
Copy link
Collaborator

Fix how we set variables in fish script

@ruben-arts ruben-arts requested review from wolfv and baszalmstra July 14, 2023 09:25
@wolfv
Copy link
Contributor

wolfv commented Jul 14, 2023

A little insta test for these could be good

@ruben-arts
Copy link
Collaborator Author

A little insta test for these could be good

Good point, added it and tested the result in a fish shell locally

@wolfv
Copy link
Contributor

wolfv commented Jul 14, 2023

Did you somehow forget to push the test?

@wolfv wolfv merged commit a98e99d into conda:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfv wolfv wolfv approved these changes

@baszalmstra baszalmstra Awaiting requested review from baszalmstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruben-arts @wolfv