Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose HasPrefixEntry for public use #784

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

kelvinou01
Copy link
Contributor

@kelvinou01 kelvinou01 commented Jul 19, 2024

I was using rattler's HasPrefix to read info/has_prefix, and I couldn't unpack the HasPrefixEntry structs contained within, because it isn't pub:

let has_prefix = HasPrefix.from_str(...)?;
has_prefix.files.into_iter()
    .map(|HasPrefixEntry { relative_path, file_mode, prefix }| {
        // do stuff with relative_path, file_mode, and prefix
    }
    .collect()

I went thru src/package/mod.rs, and I don't think making HasPrefixEntry public is bad semantics. HasPrefix is pub for downstream consumption, so I think HasPrefixEntry should be as well? Correct me if I'm wrong, this is my first contrib to rattler :)

@kelvinou01 kelvinou01 changed the title feat: expose HasPrefixEntry for public use feat: expose HasPrefixEntry for public use Jul 19, 2024
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!

@baszalmstra baszalmstra enabled auto-merge (squash) July 19, 2024 18:24
@baszalmstra baszalmstra merged commit f0d5d00 into conda:main Jul 19, 2024
19 checks passed
@baszalmstra baszalmstra mentioned this pull request Jul 19, 2024
baszalmstra added a commit that referenced this pull request Jul 23, 2024
## 🤖 New release
* `rattler_conda_types`: 0.26.1 -> 0.26.2
* `rattler`: 0.27.0 -> 0.27.1
* `rattler_cache`: 0.1.2 -> 0.1.3
* `rattler_package_streaming`: 0.21.5 -> 0.21.6
* `rattler_shell`: 0.21.1 -> 0.21.2
* `rattler_lock`: 0.22.14 -> 0.22.15
* `rattler_repodata_gateway`: 0.21.1 -> 0.21.2
* `rattler_solve`: 0.25.1 -> 0.25.2
* `rattler_virtual_packages`: 0.19.18 -> 0.19.19
* `rattler_index`: 0.19.19 -> 0.19.20

<details><summary><i><b>Changelog</b></i></summary><p>

## `rattler_conda_types`
<blockquote>

##
[0.26.2](rattler_conda_types-v0.26.1...rattler_conda_types-v0.26.2)
- 2024-07-23

### Added
- `environment.yaml` type
([#786](#786))
- Add to_path() method to ExplicitEnvironmentSpec
([#781](#781))
- expose `HasPrefixEntry` for public use
([#784](#784))
</blockquote>

## `rattler`
<blockquote>

##
[0.27.1](rattler-v0.27.0...rattler-v0.27.1)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_cache`
<blockquote>

##
[0.1.3](rattler_cache-v0.1.2...rattler_cache-v0.1.3)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_package_streaming`
<blockquote>

##
[0.21.6](rattler_package_streaming-v0.21.5...rattler_package_streaming-v0.21.6)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_shell`
<blockquote>

##
[0.21.2](rattler_shell-v0.21.1...rattler_shell-v0.21.2)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_lock`
<blockquote>

##
[0.22.15](rattler_lock-v0.22.14...rattler_lock-v0.22.15)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_repodata_gateway`
<blockquote>

##
[0.21.2](rattler_repodata_gateway-v0.21.1...rattler_repodata_gateway-v0.21.2)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_solve`
<blockquote>

##
[0.25.2](rattler_solve-v0.25.1...rattler_solve-v0.25.2)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_virtual_packages`
<blockquote>

##
[0.19.19](rattler_virtual_packages-v0.19.18...rattler_virtual_packages-v0.19.19)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_index`
<blockquote>

##
[0.19.20](rattler_index-v0.19.19...rattler_index-v0.19.20)
- 2024-07-23

### Other
- updated the following local packages: rattler_conda_types
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants