Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: channel is serialized without trailing slash #948

Merged

Conversation

baszalmstra
Copy link
Collaborator

  • ChannelUrl serializes without the trailing slash. Its information that is not needed and looks better without.
  • ChannelUrl::url returns the UrlWithTrailingSlash type. This type is autoderefed into a Url.

@baszalmstra baszalmstra requested a review from wolfv November 18, 2024 09:15
@baszalmstra baszalmstra enabled auto-merge (squash) November 18, 2024 09:24
@baszalmstra baszalmstra merged commit e9fb357 into conda:main Nov 18, 2024
15 checks passed
@baszalmstra baszalmstra mentioned this pull request Nov 18, 2024
baszalmstra added a commit that referenced this pull request Nov 18, 2024
## 🤖 New release
* `rattler_conda_types`: 0.29.1 -> 0.29.2 (✓ API compatible changes)
* `rattler`: 0.28.1 -> 0.28.2
* `rattler_cache`: 0.2.9 -> 0.2.10
* `rattler_package_streaming`: 0.22.12 -> 0.22.13
* `rattler_shell`: 0.22.6 -> 0.22.7
* `rattler_lock`: 0.22.30 -> 0.22.31
* `rattler_repodata_gateway`: 0.21.21 -> 0.21.22
* `rattler_solve`: 1.2.2 -> 1.2.3
* `rattler_virtual_packages`: 1.1.9 -> 1.1.10
* `rattler_index`: 0.19.35 -> 0.19.36

<details><summary><i><b>Changelog</b></i></summary><p>

## `rattler_conda_types`
<blockquote>

##
[0.29.2](rattler_conda_types-v0.29.1...rattler_conda_types-v0.29.2)
- 2024-11-18

### Added

- channel is serialized without trailing slash
([#948](#948))

### Other

- allow `ChannelUrl` in `Channel::from_url` interface
([#944](#944))
</blockquote>

## `rattler`
<blockquote>

##
[0.28.2](rattler-v0.28.1...rattler-v0.28.2)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_cache`
<blockquote>

##
[0.2.10](rattler_cache-v0.2.9...rattler_cache-v0.2.10)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_package_streaming`
<blockquote>

##
[0.22.13](rattler_package_streaming-v0.22.12...rattler_package_streaming-v0.22.13)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_shell`
<blockquote>

##
[0.22.7](rattler_shell-v0.22.6...rattler_shell-v0.22.7)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_lock`
<blockquote>

##
[0.22.31](rattler_lock-v0.22.30...rattler_lock-v0.22.31)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_repodata_gateway`
<blockquote>

##
[0.21.22](rattler_repodata_gateway-v0.21.21...rattler_repodata_gateway-v0.21.22)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_solve`
<blockquote>

##
[1.2.3](rattler_solve-v1.2.2...rattler_solve-v1.2.3)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_virtual_packages`
<blockquote>

##
[1.1.10](rattler_virtual_packages-v1.1.9...rattler_virtual_packages-v1.1.10)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_index`
<blockquote>

##
[0.19.36](rattler_index-v0.19.35...rattler_index-v0.19.36)
- 2024-11-18

### Other

- updated the following local packages: rattler_conda_types
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant