Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ci #163

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Fix ci #163

merged 9 commits into from
Jun 22, 2023

Conversation

Xynnn007
Copy link
Member

No description provided.

@Xynnn007
AA: update Makefile target path
d75e704 
AA now is a sub project in the workspace, so it shares the same target
directory with the top workspace.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007
ci: attestation agent only focus modifications under aa dir
81ec358 
AA is the lowest dep on the whole workspace, so only changes upon the AA
repo should be test.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007
docker build: ignore target path when using docker build
1e5c082 
target directory is too big to finish the `COPY` command in a Dockerfile

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007
ci: fix rats-tls build
0280f84 
We move the build phase of rats-tls into temp dir to avoid nested cargo
workspace issue

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007
AA: update az-snp-vtpm attester crate version
e788f37 
newest version of underlying dep `sev` changes its API and the upstream
version of `az-snp-vtpm` has some compatility fixes upon this.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007
AA: fix eaa-kbc code
2c304ab 
Wrong usage of the macro `format!`

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007
Copy link
Member Author

Xynnn007 commented Jun 21, 2023 •
edited
Loading

Hey @mkulke , to compile az-cvm-vtpm requires tss2-sys>=2.3.3 while on ubuntu only v2.3.2 could be got via apt.
https://github.com/confidential-containers/image-rs/actions/runs/5330529151/jobs/9657289027?pr=163

Could you help to resolve this?

@Xynnn007
ci: ocicrypt-rs update CI image
ab9e84a 
from runetest/compilation-testing:ubuntu18.04 to
runetest/compilation-testing:ubuntu20.04. Because 18.04 does not support
nightly toolchain for rust

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@mkulke
Copy link
Contributor

mkulke commented Jun 21, 2023

Hey @mkulke , to compile az-cvm-vtpm requires tss2-sys>=2.3.3 while on ubuntu only v2.3.2 could be got via apt. https://github.com/confidential-containers/image-rs/actions/runs/5330529151/jobs/9657289027?pr=163

Could you help to resolve this?

Are we able to bump ubuntu to 22.04? The Rust libtss wrapper won't compile ootb on older versions of libtss2. I made it compile on ubuntu 20.04 by compiling/installing a tpm2-tss tarball manually, but maybe we don't need this.

@Xynnn007
Copy link
Member Author

Are we able to bump ubuntu to 22.04? The Rust libtss wrapper won't compile ootb on older versions of libtss2. I made it compile on ubuntu 20.04 by compiling/installing a tpm2-tss tarball manually, but maybe we don't need this.

Let me take a try

@Xynnn007
Copy link
Member Author

I test locally and new version of tss stack was installed, but ubuntu 22.04 GH Runner does not

@mkulke
Copy link
Contributor

mkulke commented Jun 21, 2023 •
edited
Loading

I test locally and new version of tss stack was installed, but ubuntu 22.04 GH Runner does not

you need to explicitly install it: sudo apt-get install -y libtss2-dev, specifically

@Xynnn007
ci: install TDX & vTPM dep for image-rs
7f73c81 
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007
ci: change attestation-agent CI coverage
591ebeb 
Now cargo test in AA ci only covers attestation-agent/*

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007 Xynnn007 marked this pull request as ready for review June 22, 2023 01:53
@Xynnn007 Xynnn007 requested review from mkulke and removed request for sameo and jialez0 June 22, 2023 01:55
mkulke
mkulke approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sameo sameo merged commit a08393d into confidential-containers:main Jun 22, 2023
@Xynnn007 Xynnn007 mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkulke mkulke mkulke approved these changes

@sameo sameo sameo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xynnn007 @mkulke @sameo