Optimize implementation of image-rs/stream #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching hasher algorithm with ":", such as "sha256:" instead of "sha256". Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Simplify implementation of stream_processing(). Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
jiangliu
requested review from
sameo,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
There's an explicit memory allocation and copy operation behind `buffer[..n].to_vec()`, so optimzie code to avoid unnecessary memory copy operation. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
There's only one sender and one receiver, so replace flume with std::sync::mpsc to reduce dependency by 7. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
arronwy
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize implementation of image-rs/stream: