attestation-agent/Attesters: refactor the trait of Attester #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
reviewed
Jul 17, 2023
Xynnn007
force-pushed
the
refactor-attester
branch
from
b176633
to
a5a3724
Compare
Xynnn007
force-pushed
the
refactor-attester
branch
from
a5a3724
to
1aadb3e
Compare
sameo
approved these changes
Jul 25, 2023
Change the API of `get_evidence` function to just performing getting evidence via calling the underlying hardware drivers. Fixes: confidential-containers#283 Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Xynnn007
force-pushed
the
refactor-attester
branch
from
1aadb3e
to
705bff3
Compare
|
Rebased upstream to resolve conflicts. |
fitzthum
approved these changes
Jul 25, 2023
mkulke
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the API of
get_evidencefunction to just performing getting evidence via calling the underlying hardware drivers.Fixes: #283
Please do not merge this until the v0.8.0 cycle.
cc @jialez0 @fitzthum @mkulke please take a look if these changes are good for the architecture/concrete attester implementation.