Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aa: sgx-attester: update occlum_dcap to a tagged version #289

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Jul 21, 2023

No description provided.

@mythi mythi requested a review from jialez0 as a code owner July 21, 2023 05:22
@mythi mythi force-pushed the occlum-ver branch 2 times, most recently from 3720565 to a60317d Compare July 26, 2023 07:50
@mythi mythi changed the title aa: occlum-attester: update occlum_dcap to a tagged version aa: sgx-attester: update occlum_dcap to a tagged version Jul 26, 2023
@mythi
Copy link
Contributor Author

mythi commented Jul 26, 2023

/cc @Xynnn007

@Xynnn007
Copy link
Member

@mythi The error in CI seems to be brought by the new version of occlum. As a former PR does not has dependency devicemapper-sys https://github.com/confidential-containers/guest-components/actions/runs/5663723895/job/15345917558

@mythi
Copy link
Contributor Author

mythi commented Jul 26, 2023

The error in CI seems to be brought by the new version of occlum.

Let me take a look. It could also be because of #270

@Xynnn007
Copy link
Member

The error in CI seems to be brought by the new version of occlum.

Let me take a look. It could also be because of #270

Oh yes. There are some dep installations https://github.com/confidential-containers/guest-components/pull/270/files#diff-77d1cbd67b7597a3eb86382e96a9a71581274ba88db14b2a31415f856f895667R59-R62 which were not applied in aa_basic.yml

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Mikko!

@Xynnn007 Xynnn007 merged commit 381638a into confidential-containers:main Jul 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants