Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aliyun KMS suite #376

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Conversation

Xynnn007
Copy link
Member

  • Fixed Aliyun KMS plugin
  • Add sealed secret guide used by aliyun KMS

cc @mozillazg

Openssl was used before. However currently openssl marks RC2 in pkcs12
as `legacy`, which will cause an error when try to decrypt the
credential with password.

This commit tries to decrypt the pkcs12 manually with der bytes.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
native-tls leverages openssl that does not support RC2 in rust wrapper.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
`https://` prefix will be added when doing requests.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007 Xynnn007 merged commit 8a8044f into confidential-containers:main Oct 18, 2023
3 checks passed
@Xynnn007 Xynnn007 deleted the fix-aliyun-kms branch October 19, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants