Fixes mount parameter order in CDH/Storage/OSS #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Xynnn007
force-pushed
the
refactor-cdh-storage
branch
from
18ac459
to
26a9e84
Compare
The previous parameters of the function is not correct, s.t. using `source` as the target mount path. This commit fixes this. Also, this commit leverages the async lib to handle filesystem and time operations to avoid blocking. The last part is that in the previous version, all mount operations will share a same OSSFS_PASSWD_FILE and GOCRYPTFS_PASSWD_FILE path. This means that the operation cannot be idempotent. This is fixed by create a temp directory under /tmp for every mount operation to store those metadata files. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Xynnn007
force-pushed
the
refactor-cdh-storage
branch
from
26a9e84
to
ce0c5ae
Compare
This is a new clippy check item in cargo nightly. https://rust-lang.github.io/rust-clippy/master/index.html#/useless_vec Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous parameters of the function is not correct, s.t. using
sourceas the target mount path. This commit fixes this.Also, this commit leverages the async lib to handle filesystem and time operations to avoid blocking.
The last part is that in the previous version, all mount operations will share a same OSSFS_PASSWD_FILE and GOCRYPTFS_PASSWD_FILE path. This means that the operation cannot be idempotent. This is fixed by create a temp directory under /tmp for every mount operation to store those metadata files.
cc @LindaYu17
related to kata-containers/kata-containers#7965