Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyprovider: extend docker image and documentation #451

Merged

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Jan 24, 2024

The keyprovider docker image has been extended to bundle a keyprovider-capable skopeo and include a convenience script that simplifies the creation of encrypted images for usage in CoCo.

Documentation has been added to use the image.

@mkulke mkulke requested a review from jialez0 as a code owner January 24, 2024 12:44
@mkulke mkulke force-pushed the mkulke/extend-keyprovider-image branch from dc9dd3b to 0e5e275 Compare January 24, 2024 12:46
@mkulke
Copy link
Contributor Author

mkulke commented Jan 24, 2024

cc @bpradipt

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. It is a very coool thing and will be of great use. There are only one topic to talk about

  1. I'm not sure if it could be better to keep encrypt.sh contents outside the Dockerfile, which would do help to maintainance.

@mkulke
Copy link
Contributor Author

mkulke commented Jan 30, 2024

  1. I'm not sure if it could be better to keep encrypt.sh contents outside the Dockerfile, which would do help to maintainance.

Indeed, that makes sense. I inlined the script to make it more more portable (i.e. it doesn't matter from where you invoke docker build) but since we build the code, we have to build from project root anyway.

The keyprovider docker image has been extended to bundle a
keyprovider-capable skopeo and include a convenience script
that simplifies the creation of encrypted images for usage
in CoCo.

Documentation has been added to use the image.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke force-pushed the mkulke/extend-keyprovider-image branch from 5623d8a to 9a7d3ef Compare January 30, 2024 07:53
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mkulke mkulke merged commit 8b0dbeb into confidential-containers:main Jan 30, 2024
6 checks passed
@mkulke mkulke deleted the mkulke/extend-keyprovider-image branch January 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants