-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyprovider: extend docker image and documentation #451
keyprovider: extend docker image and documentation #451
Conversation
dc9dd3b
to
0e5e275
Compare
cc @bpradipt |
0e5e275
to
5623d8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. It is a very coool thing and will be of great use. There are only one topic to talk about
- I'm not sure if it could be better to keep
encrypt.sh
contents outside the Dockerfile, which would do help to maintainance.
Indeed, that makes sense. I inlined the script to make it more more portable (i.e. it doesn't matter from where you invoke docker build) but since we build the code, we have to build from project root anyway. |
The keyprovider docker image has been extended to bundle a keyprovider-capable skopeo and include a convenience script that simplifies the creation of encrypted images for usage in CoCo. Documentation has been added to use the image. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
5623d8a
to
9a7d3ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The keyprovider docker image has been extended to bundle a keyprovider-capable skopeo and include a convenience script that simplifies the creation of encrypted images for usage in CoCo.
Documentation has been added to use the image.