Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdh:golang support to dynamic generate go code with proto file #605

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ChengyuZhu6
Copy link
Member

Since there is already "api.proto" defining the CDH api interface in confidential-data-hub/hub/protos, we can reuse the api.proto to minimize redundant code and reduce the workload of updating the API interface.

@ChengyuZhu6 ChengyuZhu6 requested a review from sameo as a code owner July 5, 2024 03:49
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This would help to keep one origin

Since there is already "api.proto" defining the CDH api interface in `confidential-data-hub/hub/protos`,
we can reuse the api.proto to minimize redundant code and reduce the workload of updating the API interface.

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum fitzthum merged commit b669845 into confidential-containers:main Jul 8, 2024
5 checks passed
@ChengyuZhu6 ChengyuZhu6 deleted the golang-bak branch July 8, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants