cdh:storage: Add -u flag to mktemp to avoid file creation
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the -u flag to the mktemp command to generate a random name without creating a file in the `luks-encrypt-storage` script. This change ensures that mktemp only produces a unique name, which can be used as an opened device name without the side effect of file creation. Example usage: opened_device_name=$(mktemp -u "encrypted_disk_XXXXX") This update improves the script by preventing unnecessary file creation and potential errors related to file system permissions or read-only states. Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
Xynnn007
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
-uflag to the mktemp command to generate a random name without creating a file in theluks-encrypt-storagescript. This change ensures that mktemp only produces a unique name, which can be used as an opened device name without the side effect of file creation.Example usage:
opened_device_name=$(mktemp -u "encrypted_disk_XXXXX")
This update improves the script by preventing unnecessary file creation and potential errors related to file system permissions or read-only states.