This repository has been archived by the owner on Jul 2, 2023. It is now read-only.
Feature: add openssl and ring to implement block cipher
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
requested review from
sameo,
jiangliu,
arronwy and
lumjjb
as code owners
`ring` crate can provide the same random generator function as `openssl`. We add two features to implement rand_bytes - `block-cipher-ring`: based on ring, which is purely rust but cannot be built on some arch like `s390x`. - `block-cipher-openssl`: based on vendored openssl, but it requires `Make`, `C` compiler and `perl`. Fixes: #61 Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
now either openssl or ring is used to implement block cipher module. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Xynnn007
changed the title
openssl and ring to implement block cipher
arronwy
approved these changes
Apr 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ringcrate can provide the same random generator functionas
openssl. We add two features to implement rand_bytesblock-cipher-ring: based on ring, which is purely rust butcannot be built on some arch like
s390x.block-cipher-openssl: based on vendored openssl, but itrequires
Make,Ccompiler andperl.Fixes: confidential-containers/guest-components#255