Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prep for: let AS to initiate nonce/challenge #163

Closed
wants to merge 1 commit into from
Closed

prep for: let AS to initiate nonce/challenge #163

wants to merge 1 commit into from

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Sep 20, 2023

ref: #162 / 1.

@jodh-intel jodh-intel mentioned this pull request Nov 17, 2023
Merged
@fitzthum fitzthum reopened this Nov 22, 2023
@Xynnn007
Copy link
Member

Xynnn007 commented Jun 4, 2024

There are some overlap and coherance of this PR. Let me do some refactoring upon the nonce generation logic after #345 gets merged.

@mythi
Copy link
Contributor Author

mythi commented Jun 4, 2024

Let me do some refactoring upon the nonce generation logic after #345 gets merged.

I can also move this out of draft and get it merged if it helps.

@mythi
Copy link
Contributor Author

mythi commented Jun 4, 2024

Let me do some refactoring upon the nonce generation logic after #345 gets merged.

I can also move this out of draft and get it merged if it helps.

It also looks that fdbaa41 could be moved to a separate PR and have #345 rebased to use that.

@mythi
kbs: api_server: add attestation_service to auth callback
184f941 
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi mythi changed the title RFC: let AS to initiate nonce prep for: let AS to initiate nonce/challenge Jun 4, 2024
@mythi mythi marked this pull request as ready for review June 4, 2024 12:39
@mythi
Copy link
Contributor Author

mythi commented Jun 4, 2024

Let me do some refactoring upon the nonce generation logic after #345 gets merged.

I can also move this out of draft and get it merged if it helps.

It also looks that fdbaa41 could be moved to a separate PR and have #345 rebased to use that.

I made this PR to include the necessary prep work only.

@mythi
Copy link
Contributor Author

mythi commented Jun 11, 2024

Let me do some refactoring upon the nonce generation logic after #345 gets merged.

I can also move this out of draft and get it merged if it helps.

It also looks that fdbaa41 could be moved to a separate PR and have #345 rebased to use that.

too late for now so closing

@mythi mythi closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mythi @Xynnn007 @fitzthum