Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for detecting changes to flag overrides #79

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Jan 15, 2024

Describe the purpose of your pull request

Adds an optional parameter named watchChanges to createFlagOverridesFromMap which controls whether the client should detect changes to the flag override map after client initialization.

Related issues (only if applicable)

https://trello.com/c/9jqzNyAI/381-konzisztencian%C3%B6vel%C5%91-improvementek

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner January 15, 2024 16:07
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8e2e8e9) 85.93% compared to head (477348b) 86.88%.

Files Patch % Lines
src/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   85.93%   86.88%   +0.94%     
==========================================
  Files           3        3              
  Lines          64       61       -3     
  Branches       12       12              
==========================================
- Hits           55       53       -2     
+ Misses          6        5       -1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adams85 adams85 merged commit 90c4d83 into master Jan 16, 2024
25 of 26 checks passed
@adams85 adams85 deleted the feature/flag-overrides-watch-changes branch January 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants