-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobufjs@^6
triggers override mistake
#78
Comments
Thanks for bringing this up. I think we can even remove the protobufjs dependency entirely. See #79 |
Done in #79 |
Even better, thanks!! |
turadg
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Feb 26, 2024
turadg
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Feb 28, 2024
turadg
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Feb 28, 2024
turadg
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Feb 28, 2024
turadg
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Feb 28, 2024
turadg
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Hardened JavaScript and similar environments the intrinsics are frozen for security.
protobufjs
had an issue which triggered what is commonly known as the override mistake (using assignment to define a property which exists is unwritable in the prototype chain), in this caseconstructor
of a customError
.That issue was fixed, but only as part of the
^7
major version. I'm not sure if there are breaking changes impacting this package, but updatingprotobufjs
to the latest major would help projects using Hardened JS, like dapps building for the Agoric chain.The text was updated successfully, but these errors were encountered: