Compare Cosmos SDK v0.43-beta1 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move generation into root
webmaster128
reviewed
Jun 2, 2021
| @@ -189,7 +195,7 @@ export interface TallyResult { | |||
| export interface Vote { | |||
| proposalId: Long; | |||
| voter: string; | |||
| option: VoteOption; | |||
| options: WeightedVoteOption[]; | |||
There was a problem hiding this comment.
This looks incompatible as we cannot use this type for 0.42 chains anymore. Was discussed here: cosmos/cosmos-sdk#7802 (comment)
| @@ -74,6 +116,7 @@ export interface GetTxsEventRequest { | |||
| events: string[]; | |||
| /** pagination defines an pagination for the request. */ | |||
| pagination?: PageRequest; | |||
| orderBy: OrderBy; | |||
There was a problem hiding this comment.
This requires clients to set a value which does not exist in 0.42. For some reason this enum field is required by ts-proto while the message field pagination is optional.
There was a problem hiding this comment.
But with fromPartial this should not be an issue.
| @@ -56,7 +55,7 @@ export interface QueryUpgradedConsensusStateRequest { | |||
| * RPC method. | |||
| */ | |||
| export interface QueryUpgradedConsensusStateResponse { | |||
| upgradedConsensusState?: Any; | |||
| upgradedConsensusState: Uint8Array; | |||
There was a problem hiding this comment.
This seems breaking as well (cosmos/cosmos-sdk#8673 (comment))
willclarktech
force-pushed
the
main
branch
5 times, most recently
from
7c9fa44 to
de0e9f6
Compare
|
Closing in favour of #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@webmaster128 I'm not 100% on what I'm looking for here, but it looks pretty compatible overall.