Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: add authz types for bank, staking #26

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

boz
Copy link
Contributor

@boz boz commented Dec 27, 2021

also: bump version

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not familiar with how authz works. Do you only need this change for the two modules? Not more?

Could you please remove the extra zip files? They should not change as long as yarn.lock does not change. Not sure how they popped up. Do you have git LFS set up?

We use Git for version control. In addition to the well-known basics, we use the extension Git Large File Storage (LFS) to store blobs (currently *.zip). A git-lfs package is available directly in modern package repositories (Debian 10+, Ubuntu 18.04+, Homebrew, MacPorts) and as a backport for older systems. Please see this website (https://git-lfs.github.com/) for instructions how to install it.

If you installed git-lfs after cloning this repo, use this command to replace the links with the original files: git lfs fetch && git lfs checkout.

@boz
Copy link
Contributor Author

boz commented Dec 27, 2021

Hey @webmaster128 - Thanks for taking a look! I think that these were the only two missing built-in authz modules. I haven't tested it yet, tho.

I think I've sorted the .yarn/ issue - I think that it was indeed from not having installed git-lfs

@webmaster128
Copy link
Member

Thank you

@webmaster128 webmaster128 merged commit 2ea6c75 into confio:main Jan 4, 2022
@webmaster128
Copy link
Member

Released as part of 0.4.1

@nooomski
Copy link

Hey @webmaster128 , I know this one is merged a while back already, but thought I'd chime in about Authz after reading this PR. There is also a GenericAuthorization that needs to be taken into consideration, it's a Msg that takes any Msg url to authorize another account, as specified here, but I'm not sure if it needs any work on the other modules. Just wanted to let you know in case these types might be missing.

@webmaster128
Copy link
Member

Not sure when it was added but you find GenericAuthorization here: https://github.com/confio/cosmjs-types/blob/v0.4.1/src/cosmos/authz/v1beta1/authz.ts

Please note that the types are generally available in this package but not yet registered by default in CosmJS clients. See cosmos/cosmjs#1026 for the CosmJS integration in the upcoming 0.28.0. But advanced teams can do that manually already.

@nooomski
Copy link

Ah nice, thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants