Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cw2::set_contract_version in tfi-factory and tfi-pair #60

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Use cw2::set_contract_version in tfi-factory and tfi-pair #60

merged 2 commits into from
Dec 14, 2021

Conversation

ueco-jb
Copy link
Contributor

@ueco-jb ueco-jb commented Dec 14, 2021 •
edited
Loading

closes #59

@ueco-jb ueco-jb self-assigned this Dec 14, 2021
@ueco-jb ueco-jb force-pushed the 59-tfi-contracts-use-cw2-setcontractversion branch from 5948b71 to ba5f250 Compare December 14, 2021 11:15
@ueco-jb ueco-jb force-pushed the 59-tfi-contracts-use-cw2-setcontractversion branch from ba5f250 to 0909111 Compare December 14, 2021 11:20
ethanfrey
ethanfrey approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge when CI is green

contracts/tfi-factory/src/contract.rs
#[cfg_attr(not(feature = "library"), entry_point)]
pub fn instantiate(
deps: DepsMut,
_env: Env,
info: MessageInfo,
msg: InstantiateMsg,
) -> Result<Response, ContractError> {
set_contract_version(deps.storage, CONTRACT_NAME, CONTRACT_VERSION)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.

contracts/tfi-pair/src/contract.rs
#[cfg_attr(not(feature = "library"), entry_point)]
pub fn instantiate(
deps: DepsMut,
env: Env,
_info: MessageInfo,
msg: InstantiateMsg,
) -> Result<Response, ContractError> {
set_contract_version(deps.storage, CONTRACT_NAME, CONTRACT_VERSION)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

@ueco-jb ueco-jb merged commit 81b629c into main Dec 14, 2021
@ueco-jb ueco-jb deleted the 59-tfi-contracts-use-cw2-setcontractversion branch August 30, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@maurolacy maurolacy Awaiting requested review from maurolacy

Assignees

@ueco-jb ueco-jb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tfi contracts use cw2::set_contract_version
2 participants
@ueco-jb @ethanfrey