As a member of a TC I can't provide liquidity for a whitelisted/non-whitelisted pair

[kmw101]

Gist

#415 (comment)

Contract addresses were increased to 32 bytes and therefore the bech32 representation (65 chars). Max label size in wasmd is 128 chars

Description

I want to be able to create a permissionless token and then use to swap against a token linked to a Trusted Circle. When I do this in the application I get an error label is required, invalid request

To create the sequence

• As a user I create a Digital Asset which is not connected to a Trusted Circle - in this example EURO.
• I create a second Digital Asset which is connected to my Trusted Circle - in this example GREEN
• Create a pair - in this case EURO vs GREEN

[abefernan]

When creating a pair, the label that is mentioned on the error comes from the pair_name that is set on the frontend.

The pair_name is the joined addresses from the tokens: <address-of-token-a>-<address-of-token-b>. When StakeOrDie implemented the createPair functionality, they decided to use "native" as a placeholder "address" for TGD, so when creating a pair between TGD and CW20, the pair_name looks like this: native-tgrade1whateverwhatevercw20address, and when both are CW20, it looks like this: tgrade1whateverwhatevercw20addressA-tgrade1whateverwhatevercw20addressB.

What I believe it's happening is the contracts does not support such long names, and from tgrade 0.6 (I think) the addresses are longer than before, so the pair creation works for native-tgrade1whateverwhatevercw20addressveryhumongousaddress but not for tgrade1whateverwhatevercw20addressveryhumongousaddressA-tgrade1whateverwhatevercw20addressveryhumongousaddressB.

I tried using only the last 8 characters from each address for the name: addressA-addressB and I succesfully created the pair. The problem is that I think the form for providing liquidity somehow relies on that name because the provide liquidity button does not work as usual, I'm currently taking a look at that issue. UPDATE: I just found why it was not working as usual.

[maurolacy]

I also faced some issues with "label"-related errors. After creating a new token, the error "message index: 0: dispatch: submessages: label: is required: invalid request" is output when trying to provide liquidity to it.

Checking the code base, "label" seems to be an (optional) parameter to store when creating a new instance of a contract. Not sure why it's failing with "required" now.
Couldn't find any restrictions of length in the tfi code base, and neither in the tgrade one.

@alpe, could this be related to a new Cosmos SDK version?

[abefernan]

@maurolacy that is the exact issue we describe here. It happens here: https://github.com/confio/tfi/blob/main/contracts/tfi-factory/src/contract.rs#L151#L156.

I think this means label has a length limit we're exceeding.

[maurolacy]

Yes, but that code isn't failing. That's where the label is created. The code fails later, when that message is dispatched. And I couldn't find where.

[maurolacy]

Do you have a workaround for this from the frontend? Perhaps the asset info names are not being set properly? Or they can be shortened?

[abefernan]

I do have a workaround for creating them but it seems a lot of the T-Market code relies on those addresses to be full, so a lot of things start to fail.

[alpe]

Contract addresses were increased to 32 bytes and therefore the bech32 representation (65 chars). Max label size in wasmd is 128 chars