Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start global chain fee module #45

Merged
merged 4 commits into from
May 28, 2021
Merged

Start global chain fee module #45

merged 4 commits into from
May 28, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented May 21, 2021 •
edited
Loading

Resolves #7

New module with ante handler and genesis IO to enforce global minimum gas price(s)

@alpe alpe changed the title Start global chain fee decorator Start global chain fee module May 25, 2021
@alpe alpe marked this pull request as ready for review May 25, 2021 15:32
@alpe alpe requested a review from ethanfrey May 25, 2021 15:32
ethanfrey
ethanfrey approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

I would add a couple more test cases, but otherwise great to merge.

I would, however, request a follow up PR adding a grpc query to find out the minimum fee enforced by this chain.

app/app.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
docs/proto/proto-docs.md Show resolved Hide resolved
go.mod Show resolved Hide resolved
proto/confio/globalfee/v1beta1/genesis.proto Outdated Show resolved Hide resolved
x/globalfee/ante.go Outdated Show resolved Hide resolved
x/globalfee/ante_test.go Show resolved Hide resolved
x/globalfee/genesis_test.go Show resolved Hide resolved
x/globalfee/genesis_test.go Show resolved Hide resolved
x/globalfee/module.go Show resolved Hide resolved
@alpe alpe mentioned this pull request May 27, 2021
Closed
ethanfrey
ethanfrey approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes. Looking good to me.

@alpe alpe merged commit 18b227f into main May 28, 2021
@alpe alpe deleted the min_fee_7 branch May 28, 2021 06:55
@robert-zaremba
Copy link

robert-zaremba commented Jun 16, 2022 •
edited
Loading

I think you should use v1 for your proto version.

@ethanfrey
Copy link
Contributor

We try to stay consistent with the cosmos-sdk.

Why is bank still on v1beta1?

@robert-zaremba
Copy link

Because 0.1 was not possible and we weren't sure how this will evolve.
Personally i think it should have been called V1 from the beginning.
I master this is changing now to v1.

@ethanfrey
Copy link
Contributor

We will make the update once the pain of changing has been handled by the Cosmos SDK team. This is client api breaking and a big headache.

We still use Cosmos SDK 0.45 and will handle the renaming with the 0.46 update. We are also 1 week from tgrade launch and not about to rename all proto.... this is not meant for consumption by cosmos-sdk:main/0.46.x yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add consensus min_fee for gas
3 participants
@alpe @robert-zaremba @ethanfrey