-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move testhelpers' code to _test.go file #1049
Conversation
|
Thanks for this change @dmlambea |
I've done it already. It seem the "CLA not signed yet" comment has been registered after the "CLA signed" one. |
Right @dmlambea , I think the CLA signatures got reset for some reason for all the contributors at once. Could you retry signing it once, if that works? Thanks |
I've retried a minute ago with success. cla-assistant.io says: "You have agreed to the CLA for confluentinc/confluent-kafka-go" and below there is the version of the CLA (2023-08-04) along with the complete text and my personal data. |
Thank you. I created the internal branch and raised a PR with that so the CI can run. #1077 |
Merged the internal branch after CI checks. |
Fixes #1048