-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking if partitions list is empty before allocating a new list #985
Checking if partitions list is empty before allocating a new list #985
Conversation
…allow querying all partitions attached to a given consumer group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for submitting this PR!
Please also add unit tests to adminapi_test.go, one test case for nil
topic partition list, which should fail in the unit test with "context deadline exceeded", and one test with 0-sized topic partition list, which should fail with "NULL or non-empty topic partition list must be passed".
Please let me know if you require any help with the changes.
@milindl I believe the requested changes have been addressed... are any further changes required before this can be reviewed, approved and merged? Thanks! |
This looks good to me, mostly. |
@milindl Any update on this? |
The internal PR is merged. Thanks for this! It'll be released with 2.2.0 |
This check makes it possible to list all partitions assigned to a consumer group. In librdkafka, the method
rd_kafka_ListConsumerGroupOffsets
expects the partition to be NULL or having some content. However, in confluent-kafka-go a list is always created