Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load certificates from the Windows trust store WINDOWS-MY (#36) #72

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

flippingbits
Copy link
Contributor

@flippingbits flippingbits commented Oct 7, 2024

Summary of Changes

This PR adds support for loading certificates from the Windows trust store WINDOWS-MY.

Fixes #69

Any additional details or context that should be provided?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

  • Tests:
    • Added new
    • Updated existing
    • Deleted existing
  • Have you validated this change locally against a running instance of the Quarkus dev server?
    make quarkus-dev
  • Have you validated this change against a locally running native executable?
    make mvn-package-native && ./target/ide-sidecar-*-runner

flippingbits and others added 4 commits October 7, 2024 21:59
* feat: Load certificates from the Windows trust store `WINDOWS-MY`

* chore: Remove System.out.println

* chore: Update comment

* chore: Improve detection of OS

* chore: Log exception's stack trace
@flippingbits flippingbits marked this pull request as ready for review October 9, 2024 07:20
@flippingbits flippingbits requested a review from a team as a code owner October 9, 2024 07:20
@flippingbits flippingbits merged commit 0795b8e into main Oct 9, 2024
1 check passed
@flippingbits flippingbits deleted the 69-windows-trust-store branch October 9, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with Windows trust store
2 participants