Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document scala java compatibility #167

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Document scala java compatibility #167

merged 2 commits into from
Sep 25, 2018

Conversation

guozhangwang
Copy link
Contributor

@guozhangwang guozhangwang requested a review from a team September 24, 2018 21:20
@guozhangwang guozhangwang mentioned this pull request Sep 24, 2018
Closed
bbejeck
bbejeck approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guozhangwang. Just one minor typo, otherwise LGTM

README.md Outdated
@@ -211,6 +211,8 @@ IntelliJ IDEA users:
If you want to experiment with the Scala examples in this repository, you need a version of Scala that supports Java 8
and SAM / Java lambda (e.g. Scala 2.11 with `-Xexperimental` compiler flag, or 2.12).

If you are compiling with Java 9+, you'll need to have Scala version 2.12+ to be compatible with the Jav version.
Copy link
Contributor

@bbejeck bbejeck Sep 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Jav -> Java

@guozhangwang guozhangwang merged commit 7361d88 into confluentinc:5.0.0-post Sep 25, 2018
@guozhangwang guozhangwang deleted the 5.0.0-post-version-docs branch September 25, 2018 16:03
@guozhangwang
Copy link
Contributor Author

pint merged:

Checking for unmerged commits
  from 5.0.0-post to 5.0.x
    7361d88 Document scala java compatibility (#167)
  from 5.0.x to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbejeck bbejeck bbejeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guozhangwang @bbejeck