-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not call timespec_get on mac #2569
Conversation
Will it break with macOs 10.14.5 too? Also, could you provide me with the reference to #7ee0fdcfd to see the change? |
I checked the versions of XCode on my system On running the following commands, I got the responses as mentioned below: $ g++ --version $ xcode-select -v $ xcode-select --install I am guessing here that the XCode is installed for the 10.14 SDK, but the error is seen as mentioned in #2570 |
Interesting. I have clang-1100.0.33.8 with XCode 11.1. Not sure that the version of xcode-select is relevant. So maybe the loss of librdkafka is older than the latest XCode, I had not been using it in some time. I saw it break while using kafkacat in homebrew. I also based my timeline on Blizzard/node-rdkafka#686 |
Changed the version of Xcode to XCode10. The issue still persists. |
And did you try using my branch? (a usual configure/make/make install should do it. uninstall from homebrew first if needed.) |
src/rdtime.h
Outdated
@@ -195,7 +195,13 @@ static RD_INLINE void rd_timeout_init_timespec_us (struct timespec *tspec, | |||
tspec->tv_sec = timeout_us; | |||
tspec->tv_nsec = 0; | |||
} else { | |||
#if __APPLE__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unindent #... to the leftmost column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. Also changed the if to ifdef for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also rebased.
891d786
to
9aa85f4
Compare
9aa85f4
to
7249bd5
Compare
Thank you! |
@maparent Yes, I did. It worked. Thanks! |
Any ideas on when to expect a homebrew upgrade will installed this bugfixed master? |
Not for me to say, but meanwhile you can |
The brew package is either updated automatically or by community members, I haven't touched it in a long time. |
Use 1.2.2 RC1 because the gem fails on Mac otherwise. We'll wait for 1.2.2 final before the next gem release happens. confluentinc/librdkafka#2569
brew uninstall kafkacat |
New version with fix now in homebrew |
rdtime.h
avoids use of timespec on macos in general, but it was introduced in #7ee0fdcfd . With the latest 10.15 SDK, timespec_get is gone, and the library breaks.This is a very simple correction, there may be a better way.