-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MinGW Travis build issues #3607
Conversation
Perfect, thank you! |
@@ -50,6 +50,3 @@ cp ./librdkafkacpp-static.a ../dest/lib/librdkafka++-static.a | |||
popd | |||
rm -rf ./mergescratch | |||
|
|||
export PATH="$PWD/dest/bin:/mingw64/bin/:${PATH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
late comment, but these should be moved for the dynamic build script too.
Hey @neptoess , pinging you here in lack of better communication alternatives: But I'm not sure that solution (symlink/replace) is viable for our msys2 builder. Do you have any ideas? https://app.travis-ci.com/github/edenhill/librdkafka/jobs/564513967 |
Added you on LinkedIn for a communication alternative (can also provide email if you'd like). |
v1.9.0-PRE11.build.log I also just realized that the build you linked was the dynamic build (pinging @ed-alertedh @edbordin since he was involved there), but the static build worked (https://app.travis-ci.com/github/edenhill/librdkafka/jobs/564513968). The build log you linked seems to cut off without even attempting to run the tests. Bizarre. Adding a |
Yeah, turns out linkage errors are not emitted to the shell, the process just exits with a 127 return code. Do you think it would be possible just to version pin the gcc toolchain to a 10 release? |
That's kind of nasty (https://www.msys2.org/docs/package-management/#installing-a-specific-version-of-a-package-or-a-stand-alone-packages), but I'll play around with the dynamically linked build locally and see what I can figure out. |
Relative discussion in #3130