Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for an idempotent producer error, with a message batch not reconstructed identically when retried #4750

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Jun 11, 2024

Issues: #4736
Fix for an idempotent producer error, with a message batch not reconstructed identically when retried. Caused the error message "Local: Inconsistent state: Unable to reconstruct MessageSet". Happening on large batches. Solved by using the same backoff baseline for all messages in the batch.
Happens since 2.2.0

…tructed identically when retried

Issues: #4736
Fix for an idempotent producer error, with a message batch not reconstructed identically when retried. Caused the error message "Local: Inconsistent state: Unable to reconstruct MessageSet".
Happening on large batches. Solved by using the same backoff baseline for all messages in the batch.
Happens since 2.2.0
@emasab emasab requested a review from a team as a code owner June 11, 2024 16:30
Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for this fix!

CHANGELOG.md Outdated
@@ -3,6 +3,8 @@
librdkafka v2.5.0 is a feature release.

* Fix segfault when using long client id because of erased segment when using flexver. (#4689)
* Fix for an idempotent producer error, with a message batch not reconstructed
identically when retried (#)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
identically when retried (#)
identically when retried (#4750).

CHANGELOG.md Outdated
identically when retried. Caused the error message "Local: Inconsistent state: Unable to reconstruct MessageSet".
Happening on large batches. Solved by using the same backoff baseline for all messages
in the batch.
Happens since 2.2.0 (#).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Happens since 2.2.0 (#).
Happens since 2.2.0 (#4750).

@emasab emasab requested a review from milindl June 12, 2024 08:18
@emasab
Copy link
Contributor Author

emasab commented Jun 12, 2024

Closes #4736

@emasab emasab merged commit e2265b6 into master Jun 12, 2024
2 checks passed
@emasab emasab deleted the dev_fix_unable_reconstruct_messageset branch June 12, 2024 13:02
blindspotbounty pushed a commit to ordo-one/librdkafka that referenced this pull request Oct 11, 2024
…tructed identically when retried (confluentinc#4750)

Issues: confluentinc#4736
Fix for an idempotent producer error, with a message batch not reconstructed identically when retried. Caused the error message "Local: Inconsistent state: Unable to reconstruct MessageSet".
Happening on large batches. Solved by using the same backoff baseline for all messages in the batch.
Happens since 2.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants