Fallback to fetch v12 (#10) #4806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any toppars have a zero topic id
anchitj
commented
Aug 8, 2024
src/rdkafka_fetcher.c
Outdated
| @@ -943,7 +943,21 @@ static void rd_kafka_broker_fetch_reply(rd_kafka_t *rk, | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * @brief Check if any toppars have a non-zero topic id. | |||
There was a problem hiding this comment.
Will change to zero topic id
anchitj
commented
Aug 16, 2024
src/rdkafka_fetcher.c
Outdated
| rkbuf = rd_kafka_buf_new_flexver_request( | ||
|
|
||
| /* Fallback to version 12 if topic id is null which can happen if | ||
| * inter.broker.protocol.version is old */ |
7 tasks
emasab
requested changes
Sep 16, 2024
src/rdkafka_fetcher.c
Outdated
| * @brief Check if any toppars have a non-zero topic id. | ||
| * | ||
| */ | ||
| rd_bool_t can_use_topic_id(rd_kafka_broker_t *rkb) { |
There was a problem hiding this comment.
Add static, better calling it can_use_topic_ids (as in J)
Suggested change
| rd_bool_t can_use_topic_id(rd_kafka_broker_t *rkb) { | |
| static rd_bool_t can_use_topic_ids(rd_kafka_broker_t *rkb) { |
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any toppars have a zero topic id
How to Reproduce
Set inter.broker.protocol.version to 2.4 with 3.7 and fetch would fail always.