Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resource loading #246

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

jlrobins
Copy link
Contributor

@jlrobins jlrobins commented Sep 19, 2024

Summary of Changes

  • Unified the loading of common CCloud resources backing the Resources and Topics panels, improving
    performance and consistency, issue #147
  • Did so via new CCLoudResourcePreloader singleton class

Any additional details or context that should be provided?

ccloud_resource_loader_demo

All tests passing locally.

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@jlrobins jlrobins requested a review from a team as a code owner September 19, 2024 14:52
@jlrobins jlrobins merged commit e36edea into confluentinc:main Sep 19, 2024
@jlrobins jlrobins deleted the jlr/147-refactor-resource-loading branch September 19, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CCloud topic schemas don't load unless the Resources view loads environments
2 participants