You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both @bstaruk and I, we have noticed that from time-to-time the color swatch generator doesn't work as expected since we merged in #333.
Current Behavior
On random occasions, <SgColorSwatch /> doesn't load when changes are made to either CSS or JSX files. The behavior is inconsistent. At times SgColorSwatch__Colors.json gets emptied when it makes sense that nothing generates but even if it doesn't empty itself and even updates its content, the color swatches either don't get updated or don't appear on Colors page at all.
Steps to Reproduce (for bugs)
On random occasions, there are few ways I was able to reproduce the issue while working in the latest develop branch.
Make a change to colors.css or any CSS file
Make change to JSX file
I'd revert changes in json file after stopping npm run dev and then run the command again. Sometimes nothing would render on the page even though json file would regenerate with the changes or it would render the outdated changes.
The text was updated successfully, but these errors were encountered:
It appears there may be a race condition here. Since that json file kept getting regenerated on build, git kept asking me to commit it. I removed the file and added it to the .gitignore.
Next time I ran a build, the build failed because the file wasn't present. I looked in the directory and the file was there. My take is that FC tried to access the file before it was created. Looks like there may be a race condition here.
Both @bstaruk and I, we have noticed that from time-to-time the color swatch generator doesn't work as expected since we merged in #333.
Current Behavior
On random occasions,
<SgColorSwatch />
doesn't load when changes are made to either CSS or JSX files. The behavior is inconsistent. At timesSgColorSwatch__Colors.json
gets emptied when it makes sense that nothing generates but even if it doesn't empty itself and even updates its content, the color swatches either don't get updated or don't appear onColors
page at all.Steps to Reproduce (for bugs)
On random occasions, there are few ways I was able to reproduce the issue while working in the latest
develop
branch.npm run dev
and then run the command again. Sometimes nothing would render on the page even though json file would regenerate with the changes or it would render the outdated changes.The text was updated successfully, but these errors were encountered: