Bug/343: SgColorSwatches built after page load with fetch / markup.js templates #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#343
Motivation and Context
Styleguide color page had loading issues where the page would be left blank when:
A) first loading up dev and on said page.
B) made a color change in colors.css and said page refreshed.
The over all issue was that we were trying to both load and edit our colors.json export in a way that would cause build loops or stall the export of colors for a whole host of reasons.
By moving the build up of color swatches to be after page load via a XHR/fetch call to our colors.json export, we bypass the build loop issue and consistently loading the most recent exported version of our colors.json each page load.
How Has This Been Tested?
Types of changes
Checklist: