Fix conformance tests for @connectrpc/connect-web on Firefox #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
commented
Aug 26, 2024
| @@ -15,7 +15,7 @@ | |||
| "attw": "attw --pack", | |||
| "conformance:client:chrome:promise": "connectconformance --mode client --conf ./conformance/conformance-web.yaml -v -- ./conformance/client.ts --browser chrome", | |||
| "conformance:client:chrome:callback": "connectconformance --mode client --conf ./conformance/conformance-web.yaml -v --known-failing @./conformance/known-failing-callback-client.txt -- ./conformance/client.ts --browser chrome --useCallbackClient", | |||
| "conformance:client:firefox:promise": "connectconformance --mode client --conf ./conformance/conformance-web.yaml -v --known-failing @./conformance/known-failing-promise-client-firefox.txt -- ./conformance/client.ts --browser firefox", | |||
| "conformance:client:firefox:promise": "connectconformance --mode client --conf ./conformance/conformance-web.yaml -v -- ./conformance/client.ts --browser firefox", | |||
There was a problem hiding this comment.
As a result, we do not need this known-failing list anymore.
smaye81
approved these changes
Aug 26, 2024
smaye81
pushed a commit
that referenced
this pull request
Aug 26, 2024
Signed-off-by: Timo Stamm <ts@timostamm.de> Signed-off-by: Steve Ayers <sayers@buf.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1183, this updates our test setup to avoid an issue with the Firefox webdriver:
Instead of passing our script to FF's JS engine via
WebdriverIO.Browser.executeScript, we serve a HTML document that embeds the script. This slightly complicates our test setup, but it's well worth it, since there could be similar other issues that we just haven't run into yet.