Add a transform for createPromiseClient -> createClient
#1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
timostamm
reviewed
Sep 18, 2024
Signed-off-by: Sri Krishna Paritala <skrishna@buf.build>
timostamm
approved these changes
Sep 18, 2024
Merged
|
Hi, after changing to createClient, we don't get auto complete anymore 🤔 
|
|
@netanel-utila, it still works as expected over here: 
Can you check your dependency versions? |
|
Sorry for not opening an issue, but I think that's the issue. What am I doing wrong? 
"@bufbuild/buf": "1.42.0",
"@bufbuild/protobuf": "^2.1.0",
"@connectrpc/connect": "2.0.0-beta.1",
"@connectrpc/connect-node": "2.0.0-beta.1", |
|
Your dependencies are borked. If you open an issue and share your package lock file, we can take a look. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a transform for
createPromiseClient->createClientandPromiseClient->Client.