Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2.0 #929

Closed
wants to merge 2 commits into from
Closed

Release 1.2.0 #929

wants to merge 2 commits into from

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Dec 1, 2023 •
edited
Loading

What's Changed

  • Support zero-length compressed request and response messages on Node.js by @tstamm in #893.
  • Don't set User-Agent header in connect-web by @srikrsna-buf in #912.
  • Always capture header in ConnectError by @srikrsna-buf in #924.
  • Introduce ConnectRouter.rpc overload to not require full ServiceType by @paul-sachs in #925.
  • Add explicit exports for node by @smaye81 in #921.

Full Changelog: v1.1.3...v1.2.0

timostamm
timostamm reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this should be a minor release? Which features are we adding?

@smaye81
Copy link
Member Author

smaye81 commented Dec 1, 2023

I was thinking #925 at least warrants the minor bump. It introduces new, backward-compatible functionality to the public API.

@timostamm
Copy link
Member

The method added in #925 is marked with @private This is an experimental API. Please do not rely on it yet.
I don't think we should advertise it as a new feature, right? I've updated the PR title to make it clear it's experimental.

@smaye81
Copy link
Member Author

smaye81 commented Dec 1, 2023

Fair enough. We can do a patch release.

Base automatically changed from sayers/prerelease_1.2.0 to main December 1, 2023 16:36
@smaye81 smaye81 closed this Dec 1, 2023
@smaye81 smaye81 deleted the sayers/release_1.2.0 branch December 13, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smaye81 @timostamm