Override instanceof for ConnectError
#974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Jan 3, 2024
Comment on lines
140
to
148
| "code" in v && | ||
| Object.values(Code).includes(v.code as keyof Code) && | ||
| "metadata" in v && | ||
| v.metadata instanceof Headers && | ||
| "details" in v && | ||
| Array.isArray(v.details) && | ||
| "rawMessage" in v && | ||
| typeof v.rawMessage == "string" && | ||
| "cause" in v |
There was a problem hiding this comment.
instanceof Headers can be problematic because of polyfills. Let's remove this check.
Because TypeScript enums are lookup objects with numeric and string values, let's just use typeof v.code == "number".
Yes, but we don't need to bring back the individual "types" and "default" exports, as long as the typing files are next to the js files. The exports can simply be: And I believe we can also remove the "module" export. We have to test it with connectrpc/examples-es#1149 / connectrpc/examples-es#1002. |
timostamm
approved these changes
Jan 3, 2024
Merged
alecthomas
referenced
this pull request
in TBD54566975/ftl
Jan 15, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [@connectrpc/connect](https://togithub.com/connectrpc/connect-es) ([source](https://togithub.com/connectrpc/connect-es/tree/HEAD/packages/connect)) | [`1.2.1` -> `1.3.0`](https://renovatebot.com/diffs/npm/@connectrpc%2fconnect/1.2.1/1.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@connectrpc/connect-web](https://togithub.com/connectrpc/connect-es) ([source](https://togithub.com/connectrpc/connect-es/tree/HEAD/packages/connect-web)) | [`1.2.1` -> `1.3.0`](https://renovatebot.com/diffs/npm/@connectrpc%2fconnect-web/1.2.1/1.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@connectrpc/protoc-gen-connect-es](https://togithub.com/connectrpc/connect-es) ([source](https://togithub.com/connectrpc/connect-es/tree/HEAD/packages/protoc-gen-connect-es)) | [`1.2.1` -> `1.3.0`](https://renovatebot.com/diffs/npm/@connectrpc%2fprotoc-gen-connect-es/1.2.1/1.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@headlessui/react](https://togithub.com/tailwindlabs/headlessui) ([source](https://togithub.com/tailwindlabs/headlessui/tree/HEAD/packages/@headlessui-react)) | [`1.7.17` -> `1.7.18`](https://renovatebot.com/diffs/npm/@headlessui%2freact/1.7.17/1.7.18) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`6.18.0` -> `6.18.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.18.0/6.18.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`6.18.0` -> `6.18.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.18.0/6.18.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@typescript-eslint/typescript-estree](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-estree)) | [`6.18.0` -> `6.18.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2ftypescript-estree/6.18.0/6.18.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [connectrpc.com/otelconnect](https://togithub.com/connectrpc/otelconnect-go) | `v0.6.0` -> `v0.7.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/jackc/pgx/v5](https://togithub.com/jackc/pgx) | `v5.5.1` -> `v5.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [go](https://togithub.com/golang/go) | `1.21.5` -> `1.21.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | patch | | [go](https://go.dev/) ([source](https://togithub.com/golang/go)) | `1.21.5` -> `1.21.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | golang | patch | | golang.org/x/net | `v0.19.0` -> `v0.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | golang.org/x/tools | `v0.16.1` -> `v0.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [json-schema-faker](http://json-schema-faker.js.org) ([source](https://togithub.com/json-schema-faker/json-schema-faker)) | [`0.5.4` -> `0.5.5`](https://renovatebot.com/diffs/npm/json-schema-faker/0.5.4/0.5.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [just](https://togithub.com/casey/just) | `1.22.0` -> `1.23.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | minor | | [prettier](https://prettier.io) ([source](https://togithub.com/prettier/prettier)) | [`3.1.1` -> `3.2.2`](https://renovatebot.com/diffs/npm/prettier/3.1.1/3.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [protoc](https://togithub.com/protocolbuffers/protobuf) | `25.1` -> `25.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | minor | | [react-router-dom](https://togithub.com/remix-run/react-router) ([source](https://togithub.com/remix-run/react-router/tree/HEAD/packages/react-router-dom)) | [`6.21.1` -> `6.21.2`](https://renovatebot.com/diffs/npm/react-router-dom/6.21.1/6.21.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [org.codehaus.mojo:flatten-maven-plugin](https://www.mojohaus.org/flatten-maven-plugin/) ([source](https://togithub.com/mojohaus/flatten-maven-plugin)) | `1.5.0` -> `1.6.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | build | minor | | [org.apache.maven.plugins:maven-surefire-plugin](https://maven.apache.org/surefire/) | `3.2.3` -> `3.2.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | build | patch | | [io.grpc:grpc-stub](https://togithub.com/grpc/grpc-java) | `1.60.1` -> `1.61.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | compile | minor | | [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | `1.60.1` -> `1.61.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | compile | minor | | [io.grpc:grpc-netty](https://togithub.com/grpc/grpc-java) | `1.60.1` -> `1.61.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | compile | minor | --- ### Release Notes <details> <summary>connectrpc/connect-es (@​connectrpc/connect)</summary> ### [`v1.3.0`](https://togithub.com/connectrpc/connect-es/releases/tag/v1.3.0) [Compare Source](https://togithub.com/connectrpc/connect-es/compare/v1.2.1...v1.3.0) ##### What's Changed - Export `*TransportOptions` types for `connect-node` by [@​jrschumacher](https://togithub.com/jrschumacher) in [https://github.com/connectrpc/connect-es/pull/959](https://togithub.com/connectrpc/connect-es/pull/959) - Override `instanceof` for `ConnectError` by [@​srikrsna-buf](https://togithub.com/srikrsna-buf) in [https://github.com/connectrpc/connect-es/pull/974](https://togithub.com/connectrpc/connect-es/pull/974) ##### New Contributors - [@​jrschumacher](https://togithub.com/jrschumacher) made their first contribution in [https://github.com/connectrpc/connect-es/pull/959](https://togithub.com/connectrpc/connect-es/pull/959) **Full Changelog**: connectrpc/connect-es@v1.2.1...v1.3.0 </details> <details> <summary>tailwindlabs/headlessui (@​headlessui/react)</summary> ### [`v1.7.18`](https://togithub.com/tailwindlabs/headlessui/blob/HEAD/packages/@​headlessui-react/CHANGELOG.md#1718---2024-01-08) [Compare Source](https://togithub.com/tailwindlabs/headlessui/compare/@headlessui/react@v1.7.17...@headlessui/react@v1.7.18) ##### Fixed - Don't call `<Dialog>`'s `onClose` twice on mobile devices ([#​2690](https://togithub.com/tailwindlabs/headlessui/pull/2690)) - Lazily resolve default containers in `<Dialog>` ([#​2697](https://togithub.com/tailwindlabs/headlessui/pull/2697)) - Ensure hidden `Tab.Panel` components are hidden from the accessibility tree ([#​2708](https://togithub.com/tailwindlabs/headlessui/pull/2708)) - Add support for `role="alertdialog"` to `<Dialog>` component ([#​2709](https://togithub.com/tailwindlabs/headlessui/pull/2709)) - Ensure blurring the `Combobox.Input` component closes the `Combobox` ([#​2712](https://togithub.com/tailwindlabs/headlessui/pull/2712)) - Allow changes to the `className` prop when the `<Transition />` component is currently not transitioning ([#​2722](https://togithub.com/tailwindlabs/headlessui/pull/2722)) - Export (internal-only) component interfaces for TypeScript compiler ([#​2313](https://togithub.com/tailwindlabs/headlessui/pull/2313)) - Fix infinite render-loop for `<Disclosure.Panel>` and `<Popover.Panel>` when `as={Fragment}` ([#​2760](https://togithub.com/tailwindlabs/headlessui/pull/2760)) - Fix VoiceOver bug for `Listbox` component in Chrome ([#​2824](https://togithub.com/tailwindlabs/headlessui/pull/2824)) - Fix outside click detection when component is mounted in the Shadow DOM ([#​2866](https://togithub.com/tailwindlabs/headlessui/pull/2866)) - Fix CJS types ([#​2880](https://togithub.com/tailwindlabs/headlessui/pull/2880)) - Fix error when transition classes contain new lines ([#​2871](https://togithub.com/tailwindlabs/headlessui/pull/2871)) - Improve iOS locking ([7721aca](https://togithub.com/tailwindlabs/headlessui/commit/7721acaecea2008c2d7e8ab29cc8d45b70bb021e)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v6.18.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6181-2024-01-08) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.18.0...v6.18.1) ##### 🩹 Fixes - **eslint-plugin:** \[no-non-null-assertion] provide valid fix when member access is on next line - **eslint-plugin:** \[no-unnecessary-condition] improve checking optional callee - **eslint-plugin:** \[prefer-readonly] support modifiers of unions and intersections - **eslint-plugin:** \[switch-exhaustiveness-check] fix new allowDefaultCaseForExhaustiveSwitch option ##### ❤️ Thank You - auvred - James - Josh Goldberg ✨ - YeonJuan You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v6.18.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#6181-2024-01-08) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.18.0...v6.18.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/typescript-estree)</summary> ### [`v6.18.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-estree/CHANGELOG.md#6181-2024-01-08) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.18.0...v6.18.1) ##### 🩹 Fixes - **typescript-estree:** fix invalid parsing error when use update expression on non-null assertion - **typescript-estree:** only create project service from env setting if project is enabled ##### ❤️ Thank You - auvred - James - Josh Goldberg ✨ - YeonJuan You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>connectrpc/otelconnect-go (connectrpc.com/otelconnect)</summary> ### [`v0.7.0`](https://togithub.com/connectrpc/otelconnect-go/releases/tag/v0.7.0) [Compare Source](https://togithub.com/connectrpc/otelconnect-go/compare/v0.6.0...v0.7.0) This release includes API changes that are not backwards-compatible. Migrating to the new API should be mechanical in most cases. ##### What's Changed ##### Bugfixes - Eagerly create instruments to fail fast on initialization by [@​emcfarlane](https://togithub.com/emcfarlane) in [#​141](https://togithub.com/connectrpc/otelconnect-go/issues/141) - *This is a breaking change.* The `NewInterceptor` factory function can now return an error. - Align gRPC server status code to span status code by [@​dragon3](https://togithub.com/dragon3) in [#​144](https://togithub.com/connectrpc/otelconnect-go/issues/144) - Fix histogram counter for per RPC counts by [@​emcfarlane](https://togithub.com/emcfarlane) in [#​151](https://togithub.com/connectrpc/otelconnect-go/issues/151) - Mark stream operations complete correctly and promptly, including on context cancellation by [@​emcfarlane](https://togithub.com/emcfarlane) in [#​152](https://togithub.com/connectrpc/otelconnect-go/issues/152) - Fix streaming client context by [@​emcfarlane](https://togithub.com/emcfarlane) in [#​153](https://togithub.com/connectrpc/otelconnect-go/issues/153) - *This is a breaking change.* In order to fix span and context creation, the filter and attribute filter types had to change since not all information previously provided in the `otelconnect.Request` parameter was actually available in client-streaming operations. Filters now receive a `*connect.Spec` instead. With these filter types changed, `otelconnect.Request` was no longer used so has been deleted. ##### Enhancements - Add descriptions to metrics to match otelgrpc by [@​charithe](https://togithub.com/charithe) in [#​155](https://togithub.com/connectrpc/otelconnect-go/issues/155) ##### Other changes - Improvements in tests and benchmarks and updates of dependencies by [@​emcfarlane](https://togithub.com/emcfarlane) in [#​139](https://togithub.com/connectrpc/otelconnect-go/issues/139), [#​140](https://togithub.com/connectrpc/otelconnect-go/issues/140), and [#​145](https://togithub.com/connectrpc/otelconnect-go/issues/145) ##### New Contributors - [@​charithe](https://togithub.com/charithe) made their first contribution in [#​155](https://togithub.com/connectrpc/otelconnect-go/issues/155) - [@​dragon3](https://togithub.com/dragon3) made their first contribution in [#​144](https://togithub.com/connectrpc/otelconnect-go/issues/144) **Full Changelog**: connectrpc/otelconnect-go@v0.6.0...v0.7.0 </details> <details> <summary>jackc/pgx (github.com/jackc/pgx/v5)</summary> ### [`v5.5.2`](https://togithub.com/jackc/pgx/compare/v5.5.1...v5.5.2) [Compare Source](https://togithub.com/jackc/pgx/compare/v5.5.1...v5.5.2) </details> <details> <summary>golang/go (go)</summary> ### [`v1.21.6`](https://togithub.com/golang/go/compare/go1.21.5...go1.21.6) </details> <details> <summary>json-schema-faker/json-schema-faker (json-schema-faker)</summary> ### [`v0.5.5`](https://togithub.com/json-schema-faker/json-schema-faker/compare/v0.5.4...v0.5.5) [Compare Source](https://togithub.com/json-schema-faker/json-schema-faker/compare/v0.5.4...v0.5.5) </details> <details> <summary>casey/just (just)</summary> ### [`v1.23.0`](https://togithub.com/casey/just/blob/HEAD/CHANGELOG.md#1230---2024-01-12) [Compare Source](https://togithub.com/casey/just/compare/1.22.1...1.23.0) ##### Added - Allow setting custom confirm prompt ([#​1834](https://togithub.com/casey/just/pull/1834) by [CramBL](https://togithub.com/CramBL)) - Add `set quiet` and `[no-quiet]` ([#​1704](https://togithub.com/casey/just/pull/1704) by [dharrigan](https://togithub.com/dharrigan)) - Add `just_pid` function ([#​1833](https://togithub.com/casey/just/pull/1833) by [Swordelf2](https://togithub.com/Swordelf2)) - Add functions to return XDG base directories ([#​1822](https://togithub.com/casey/just/pull/1822) by [tgross35](https://togithub.com/tgross35)) - Add `--no-deps` to skip running recipe dependencies ([#​1819](https://togithub.com/casey/just/pull/1819) by [ngharrington](https://togithub.com/ngharrington)) ##### Fixed - Run imports in working directory of importer ([#​1817](https://togithub.com/casey/just/pull/1817)) ##### Misc - Include completion scripts in releases ([#​1837](https://togithub.com/casey/just/pull/1837)) - Tweak readme table formatting ([#​1836](https://togithub.com/casey/just/pull/1836)) - Don't abbreviate just in README ([#​1831](https://togithub.com/casey/just/pull/1831) by [thled](https://togithub.com/thled)) - Ignore \[private] recipes in just --list ([#​1816](https://togithub.com/casey/just/pull/1816) by [crdx](https://togithub.com/crdx)) - Add a dash to tempdir prefix ([#​1828](https://togithub.com/casey/just/pull/1828)) ### [`v1.22.1`](https://togithub.com/casey/just/blob/HEAD/CHANGELOG.md#1221---2024-01-08) [Compare Source](https://togithub.com/casey/just/compare/1.22.0...1.22.1) ##### Fixed - Don't conflate recipes with the same name in different modules ([#​1825](https://togithub.com/casey/just/pull/1825)) ##### Misc - Clarify that UUID is version 4 ([#​1821](https://togithub.com/casey/just/pull/1821) by [tgross35](https://togithub.com/tgross35)) - Make sigil stripping from recipe lines less incomprehensible ([#​1812](https://togithub.com/casey/just/pull/1812)) - Refactor invalid path argument check ([#​1811](https://togithub.com/casey/just/pull/1811)) </details> <details> <summary>prettier/prettier (prettier)</summary> ### [`v3.2.2`](https://togithub.com/prettier/prettier/blob/HEAD/CHANGELOG.md#322) [Compare Source](https://togithub.com/prettier/prettier/compare/3.2.1...3.2.2) [diff](https://togithub.com/prettier/prettier/compare/3.2.1...3.2.2) ##### Fix crash when parsing template literal CSS in a JSX style tag using a spread attribute ([#​15896](https://togithub.com/prettier/prettier/pull/15896) by [@​eelco](https://togithub.com/eelco)) For example this code would crash before: <!-- prettier-ignore --> ```jsx <style {...spread}>{`.{}`}</style> ``` ##### Fix formatting error on optional call expression and member chain ([#​15920](https://togithub.com/prettier/prettier/pull/15920) by [@​sosukesuzuki](https://togithub.com/sosukesuzuki)) <!-- prettier-ignore --> ```jsx // Input a(() => {}, c?.d()); // Prettier 3.2.1 TypeError: Cannot read properties of undefined (reading 'type') // Prettier 3.2.2 a(() => {}, c?.d()); ``` ### [`v3.2.1`](https://togithub.com/prettier/prettier/blob/HEAD/CHANGELOG.md#321) [Compare Source](https://togithub.com/prettier/prettier/compare/3.2.0...3.2.1) [diff](https://togithub.com/prettier/prettier/compare/3.2.0...3.2.1) ##### Fix formatting error on member chain ([#​15915](https://togithub.com/prettier/prettier/pull/15915) by [@​sosukesuzuki](https://togithub.com/sosukesuzuki)) <!-- prettier-ignore --> ```jsx // Input test().test2().test2(thing?.something); // Prettier 3.2.0 TypeError: Cannot read properties of undefined (reading 'type') // Prettier 3.2.1 test().test2().test2(thing?.something); ``` ### [`v3.2.0`](https://togithub.com/prettier/prettier/blob/HEAD/CHANGELOG.md#320) [Compare Source](https://togithub.com/prettier/prettier/compare/3.1.1...3.2.0) [diff](https://togithub.com/prettier/prettier/compare/3.1.1...3.2.0) 🔗 [Release Notes](https://prettier.io/blog/2024/01/13/3.2.0.html) </details> <details> <summary>protocolbuffers/protobuf (protoc)</summary> ### [`v25.2`](https://togithub.com/protocolbuffers/protobuf/releases/tag/v25.2): Protocol Buffers v25.2 ### Announcements - [Protobuf News](https://protobuf.dev/news/) may include additional announcements or pre-announcements for upcoming changes. ### C++ - Only substitute prefixes during installation setup. (protocolbuffers/protobuf@05ad652) - Register a shutdown delete for C++ feature defaults (protocolbuffers/protobuf@3d5c709) </details> <details> <summary>remix-run/react-router (react-router-dom)</summary> ### [`v6.21.2`](https://togithub.com/remix-run/react-router/compare/react-router-dom@6.21.1...react-router-dom@6.21.2) [Compare Source](https://togithub.com/remix-run/react-router/compare/react-router-dom@6.21.1...react-router-dom@6.21.2) </details> <details> <summary>mojohaus/flatten-maven-plugin (org.codehaus.mojo:flatten-maven-plugin)</summary> ### [`v1.6.0`](https://togithub.com/mojohaus/flatten-maven-plugin/releases/tag/1.6.0) [Compare Source](https://togithub.com/mojohaus/flatten-maven-plugin/compare/1.5.0...1.6.0) <!-- Optional: add a release summary here --> #### 🚀 New features and improvements - Require Maven 3.6.3 as minimum ([#​399](https://togithub.com/mojohaus/flatten-maven-plugin/pull/399)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) - Make the default operation configurable ([#​371](https://togithub.com/mojohaus/flatten-maven-plugin/pull/371)) [@​hgschmie](https://togithub.com/hgschmie) - Add skip flags ([#​385](https://togithub.com/mojohaus/flatten-maven-plugin/pull/385)) [@​korthout](https://togithub.com/korthout) - Make more elements configurable in pomElements ([#​370](https://togithub.com/mojohaus/flatten-maven-plugin/pull/370)) [@​hgschmie](https://togithub.com/hgschmie) #### 🐛 Bug Fixes - Fix next ITs for Maven 4 ([#​393](https://togithub.com/mojohaus/flatten-maven-plugin/pull/393)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) - [#​376](https://togithub.com/mojohaus/flatten-maven-plugin/issues/376) :bug: - Support interpolation for external profile properties ([#​378](https://togithub.com/mojohaus/flatten-maven-plugin/pull/378)) [@​CedricMtta](https://togithub.com/CedricMtta) #### 📦 Dependency updates - Bump plexus-utils from 3.5.1 to 4.0.0 ([#​359](https://togithub.com/mojohaus/flatten-maven-plugin/pull/359)) [@​dependabot](https://togithub.com/dependabot) - Bump org.codehaus.mojo:mojo-parent from 77 to 78 ([#​392](https://togithub.com/mojohaus/flatten-maven-plugin/pull/392)) [@​dependabot](https://togithub.com/dependabot) - Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 ([#​391](https://togithub.com/mojohaus/flatten-maven-plugin/pull/391)) [@​dependabot](https://togithub.com/dependabot) - Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 ([#​389](https://togithub.com/mojohaus/flatten-maven-plugin/pull/389)) [@​dependabot](https://togithub.com/dependabot) - Bump commons-io:commons-io from 2.15.0 to 2.15.1 ([#​388](https://togithub.com/mojohaus/flatten-maven-plugin/pull/388)) [@​dependabot](https://togithub.com/dependabot) - Bump commons-io:commons-io from 2.14.0 to 2.15.0 ([#​381](https://togithub.com/mojohaus/flatten-maven-plugin/pull/381)) [@​dependabot](https://togithub.com/dependabot) - Bump org.codehaus.mojo:mojo-parent from 76 to 77 ([#​380](https://togithub.com/mojohaus/flatten-maven-plugin/pull/380)) [@​dependabot](https://togithub.com/dependabot) - Bump commons-io:commons-io from 2.13.0 to 2.14.0 ([#​375](https://togithub.com/mojohaus/flatten-maven-plugin/pull/375)) [@​dependabot](https://togithub.com/dependabot) - upgrade sisu.inject: fixes Reproducible Builds ([#​357](https://togithub.com/mojohaus/flatten-maven-plugin/pull/357)) [@​hboutemy](https://togithub.com/hboutemy) - Bump guava from 31.1-jre to 32.0.0-jre in /src/it/projects/bom-pomElements/bom ([#​364](https://togithub.com/mojohaus/flatten-maven-plugin/pull/364)) [@​dependabot](https://togithub.com/dependabot) - Bump guava from 31.1-jre to 32.0.0-jre in /src/it/projects/flatten-shaded-drp ([#​365](https://togithub.com/mojohaus/flatten-maven-plugin/pull/365)) [@​dependabot](https://togithub.com/dependabot) - Bump guava from 31.1-jre to 32.0.0-jre in /src/it/projects/bom-flattenMode/bom ([#​363](https://togithub.com/mojohaus/flatten-maven-plugin/pull/363)) [@​dependabot](https://togithub.com/dependabot) - Bump mojo-parent from 74 to 76 ([#​366](https://togithub.com/mojohaus/flatten-maven-plugin/pull/366)) [@​dependabot](https://togithub.com/dependabot) - Bump commons-io from 2.12.0 to 2.13.0 ([#​361](https://togithub.com/mojohaus/flatten-maven-plugin/pull/361)) [@​dependabot](https://togithub.com/dependabot) - Bump commons-io from 2.11.0 to 2.12.0 ([#​358](https://togithub.com/mojohaus/flatten-maven-plugin/pull/358)) [@​dependabot](https://togithub.com/dependabot) #### 👻 Maintenance - upgrade sisu.inject: fixes Reproducible Builds ([#​357](https://togithub.com/mojohaus/flatten-maven-plugin/pull/357)) [@​hboutemy](https://togithub.com/hboutemy) #### 🔧 Build - Use default config for build ([#​398](https://togithub.com/mojohaus/flatten-maven-plugin/pull/398)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) - Use Shared ASF Action from Release Drafter - fix ([#​396](https://togithub.com/mojohaus/flatten-maven-plugin/pull/396)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) - Use Shared ASF Action from Release Drafter ([#​395](https://togithub.com/mojohaus/flatten-maven-plugin/pull/395)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) - Use Maven 3.9.6 for build ([#​394](https://togithub.com/mojohaus/flatten-maven-plugin/pull/394)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) </details> <details> <summary>grpc/grpc-java (io.grpc:grpc-stub)</summary> ### [`v1.61.0`](https://togithub.com/grpc/grpc-java/compare/v1.60.1...v1.61.0) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.60.1...v1.61.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/TBD54566975/ftl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Feb 12, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override
instanceofforConnectError. This will help solve theinstanceofchecks failing due to the dual package hazard (i.e. two different versions of connect causing theinstanceofchecks to fail).We can also simplify the changes done in #842 and export without the wrappers like we did before.