Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Remove option for AbortSignal from useMutation #422

Merged

Conversation

timostamm
Copy link
Member

I noticed that useMutation accepts CallOptions.signal, but other hooks do not. This removes the option.

I'm not sure why it would be desirable to cancel a mutation. If I'm missing something, please let me know.

Signed-off-by: Timo Stamm <ts@timostamm.de>
@timostamm timostamm changed the title Remove option for AbortSignal from useMutation V2: Remove option for AbortSignal from useMutation Sep 26, 2024
Copy link
Collaborator

@paul-sachs paul-sachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@timostamm timostamm merged commit 02cc5bc into v2 Sep 26, 2024
6 of 8 checks passed
@timostamm timostamm deleted the tstamm/v2/Remove-option-for-AbortSignal-from-useMutation branch September 26, 2024 13:13
@timostamm timostamm mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants