V2: Replace disableQuery with skipToken #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
commented
Sep 27, 2024
| ...baseOptions, | ||
| ...queryOptions, |
There was a problem hiding this comment.
This change accepts all TanStack Query options, even if they override an option provided by us. The types are changed to allow all options.
queryFn and queryKey are still typed, since the option type is not inferred.
There was a problem hiding this comment.
@paul-sachs, I've reverted the change to the types in 786fde4.
This means we do not allow overriding computed options with this PR. We can still merge the users options into our options in the hooks because TanStack Query honors the skipToken on it's own and we don't have to set enabled: false. We can allow overriding later if needed.
There was a problem hiding this comment.
Makes sense to me, might as well keep them in separate PRs anyways.
This was referenced Sep 27, 2024
Merged
Signed-off-by: Timo Stamm <ts@timostamm.de>
…leQuery-with-skipToken,-allow-overriding-computed-options
Enabling typechecking tests with vitest. --------- Signed-off-by: Paul Sachs <psachs@buf.build>
…ableQuery-with-skipToken,-allow-overriding-computed-options Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
force-pushed
the
tstamm/v2/Replace-disableQuery-with-skipToken,-allow-overriding-computed-options
branch
from
c9104be
to
fdd0eba
Compare
…leQuery-with-skipToken,-allow-overriding-computed-options
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
changed the title
paul-sachs
approved these changes
Sep 30, 2024
timostamm
deleted the
tstamm/v2/Replace-disableQuery-with-skipToken,-allow-overriding-computed-options
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TanStack query added skipToken - we can use it instead of
disableQuery.