V2: Remove CallOptions #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
commented
Oct 3, 2024
| export async function callUnaryMethod< | ||
| I extends DescMessage, | ||
| O extends DescMessage, | ||
| >( | ||
| transport: Transport, |
There was a problem hiding this comment.
Removing CallOptions is a breaking change, but we're also changing the function signature here. Transport is strictly necessary to make a call, so I think it's a better fit to let it be a required argument than part of an options argument.
Signed-off-by: Timo Stamm <ts@timostamm.de>
paul-sachs
approved these changes
Oct 3, 2024
This was referenced Oct 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooks and several other functions accept
CallOptionsfrom@connectrpc/connect. In general, every Connect client should accept a call options argument, but they don't work well with TanStack Query's caching.For now, we're removing
CallOptionsfrom the function arguments in v2.