-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: arbitrum slowpath processing #6344
Open
LayneHaber
wants to merge
10
commits into
main
Choose a base branch
from
fix-slowpath-processing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayneHaber
requested review from
preethamr,
liu-zhipeng,
wanglonghong and
just-a-node
as code owners
August 22, 2024 16:24
preethamr
previously requested changes
Aug 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still fails e2e on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to dependencies and refactors to improve the codebase's compatibility with the latest versions of the
@arbitrum/sdk
package. The changes involve updating package dependencies, modifying imports and exports, and adjusting test cases to reflect the new SDK structure.Dependency Updates:
@arbitrum/sdk
to version4.0.1
and@eth-optimism/sdk
to version3.3.2
inpackages/agents/lighthouse/package.json
andpackages/deployments/contracts/package.json
. [1] [2]Code Refactoring:
L2TransactionReceipt
withChildTransactionReceipt
andL1ToL2MessageGasEstimator
withParentToChildMessageGasEstimator
across multiple files includingpackages/agents/lighthouse/src/mockable.ts
andpackages/agents/lighthouse/src/tasks/processFromRoot/helpers/arbitrum.ts
. [1] [2] [3] [4] [5] [6] [7] [8]Test Adjustments:
L2ToL1MessageReader
withChildToParentMessageReader
inpackages/agents/lighthouse/test/tasks/processFromRoot/helpers/arbitrum.spec.ts
andpackages/agents/lighthouse/test/tasks/propagate/helpers/arbitrum.spec.ts
. [1] [2] [3] [4]New Features:
packages/agents/lighthouse/example.http
.These changes ensure that the codebase remains up-to-date with the latest SDK versions and maintain compatibility across different modules.## Description
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)