REP-45 Add option to delete replication data through UI #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed up changes for comments on #45 |
mcalcote
approved these changes
Mar 29, 2019
...api-impl/src/main/java/org/codice/ditto/replication/api/impl/ScheduledReplicatorDeleter.java
Show resolved
Hide resolved
replication-api/src/main/java/org/codice/ditto/replication/api/data/ReplicatorConfig.java
Outdated
Show resolved
Hide resolved
kcover
reviewed
Mar 29, 2019
| try { | ||
| persistentStore.get(ReplicatorConfigImpl.class, configId); | ||
| persistentStore.get(ReplicatorConfigImpl.class, id); | ||
| } catch (NotFoundException | ReplicationPersistenceException e) { |
There was a problem hiding this comment.
we might want the ReplicationPersistenceException to bubble out, rather than just returning false when we actually don't know. Same goes for this method in the SiteManagerImpl
paouelle
approved these changes
Apr 2, 2019
...api-impl/src/main/java/org/codice/ditto/replication/api/impl/ScheduledReplicatorDeleter.java
Show resolved
Hide resolved
...-api-impl/src/main/java/org/codice/ditto/replication/api/impl/data/ReplicatorConfigImpl.java
Outdated
Show resolved
Hide resolved
| @Mock CatalogFramework catalogFramework; | ||
|
|
||
| @Before | ||
| public void setup() { |
There was a problem hiding this comment.
❓ Why use a setup method her as opposed to just putting this in the attribute initialization above?
There was a problem hiding this comment.
No reason in particular.
replication-api/src/main/java/org/codice/ditto/replication/api/data/ReplicatorConfig.java
Outdated
Show resolved
Hide resolved
clockard
approved these changes
Apr 2, 2019
clockard
approved these changes
Apr 2, 2019
| @@ -43,7 +43,7 @@ const HelpDialog = props => { | |||
| return ( | |||
| <Dialog open={open} onClose={handleClose} maxWidth='md'> | |||
| <DialogTitle variant='h6' id='help-dialog-title'> | |||
| {'Welcome to the Project Charleston BETA'} | |||
There was a problem hiding this comment.
This removes it from the welcome dialog but not the navbar at the top of the page. Looks like there is one more removal needed
There was a problem hiding this comment.
Whoops, removed.
|
Manually verified functionality ✅ |
kcover
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closed #52 to open against 0.2.x. I will apply comments from that PR.
Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?
@clockard @paouelle @kcover @mcalcote
How should this be tested? (List steps with links to updated documentation)
Make sure
/solrcan be accessed to check replication items.Any background context you want to provide?
What are the relevant tickets?
Fixes #45
Screenshots (if appropriate)
Checklist: